Skip to content

Isosurface example #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 26, 2023
Merged

Isosurface example #1056

merged 15 commits into from
Jul 26, 2023

Conversation

MichaelNale
Copy link
Contributor

Create example for mesh_cut operator for iso-surfaces using fluid files.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1056 (9df35ef) into master (8b3d645) will increase coverage by 1.15%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master    #1056      +/-   ##
==========================================
+ Coverage   87.05%   88.20%   +1.15%     
==========================================
  Files          78       78              
  Lines        8984     8998      +14     
==========================================
+ Hits         7821     7937     +116     
+ Misses       1163     1061     -102     

Enable to implement a field with overall location
Plot iso surface as overall location field
Implement a setter for field's name
Complete iso-surface example to make it more readable
Give the possibility through fields_factory to create an overall location field
Reformat the example
Add ValueError message for faces location in plotter
@PProfizi PProfizi changed the title Mnale/add isosurface example Isosurface example Jul 25, 2023
@PProfizi PProfizi added the examples Related to PyDPF-Core examples label Jul 25, 2023
@PProfizi PProfizi added this to the v0.9.0 milestone Jul 25, 2023
@MichaelNale
Copy link
Contributor Author

@JennaPaikowsky is it possible for you to take a look at this PR please?

Copy link
Contributor

@JennaPaikowsky JennaPaikowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions

@MichaelNale MichaelNale merged commit 6267e78 into master Jul 26, 2023
@MichaelNale MichaelNale deleted the mnale/add_isosurface_example branch July 26, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Related to PyDPF-Core examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants