-
Notifications
You must be signed in to change notification settings - Fork 25
Isosurface example #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Isosurface example #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
+ Coverage 87.05% 88.20% +1.15%
==========================================
Files 78 78
Lines 8984 8998 +14
==========================================
+ Hits 7821 7937 +116
+ Misses 1163 1061 -102 |
rafacanton
reviewed
Jul 24, 2023
Enable to implement a field with overall location Plot iso surface as overall location field
Implement a setter for field's name Complete iso-surface example to make it more readable
Give the possibility through fields_factory to create an overall location field Reformat the example Add ValueError message for faces location in plotter
rafacanton
reviewed
Jul 25, 2023
rafacanton
reviewed
Jul 25, 2023
@JennaPaikowsky is it possible for you to take a look at this PR please? |
JennaPaikowsky
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few suggestions
rafacanton
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create example for mesh_cut operator for iso-surfaces using fluid files.