-
Notifications
You must be signed in to change notification settings - Fork 9
fix bug 1250066 concerning point with skin extraction #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 52 52
Lines 5210 5210
=======================================
Hits 4435 4435
Misses 775 775 🚀 New features to boost your workflow:
|
@rlagha |
@PProfizi I don't understand why commenting a test make those checks fail. Locally everything's fine BTW. |
@MichaelNale @PProfizi Because the failure in the examples is unrelated to this change. It is related to the issue in this PR: #820 |
@MichaelNale Could you not add an additional input "add_beam_point" and keep the current add_beam input. You could then deprecate the add_beam input. There are other clients such as Result Explorer that will break due to this change. |
change add_beam to add_beam_point to be compliant with changes server side