feat: Initial bulk of type checking + setup by Gobot1234 · Pull Request #4761 · ansys/pyfluent

Gobot1234 · 2025-12-18T01:55:54Z

Context

Duplicate of #4500 but on the ansys remote. Looking at this code more, I realise I've ran pyupgrade on this so don't merge this till I get the rest of the ruff stuff set up. I'm also realising there are 3 issues tied up in this, apologies for that.
Fixes #4489 and fixes #4490
Helps with #4543

Change Summary

Added a bunch of initial types for the public facing library part of #4738

Gobot1234 · 2025-12-18T01:57:02Z

src/ansys/fluent/core/launcher/container_launcher.py

-        }
-        self.argvals, self.new_session = _get_argvals_and_session(argvals)
-        if self.argvals["start_timeout"] is None:
+        self.argvals, self.new_session = _get_argvals_and_session(


This was changed as sadly there's no way to type transform a typedict to have optional keys (python isn't typescript, sad)

src/ansys/fluent/core/launcher/launcher.py

src/ansys/fluent/core/session_pure_meshing.py

src/ansys/fluent/core/session_solver.py

Gobot1234 · 2025-12-18T02:03:02Z

I'll try and get to the conflicts soonish, probably more useful to get the ruff changes in first

…s/pyfluent into jhilton/typing-improvements

…ements

src/ansys/fluent/core/launcher/slurm_launcher.py

…s/pyfluent into jhilton/typing-improvements

Copilot

Pull request overview

Copilot reviewed 92 out of 94 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 92 out of 94 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

src/ansys/fluent/core/launcher/watchdog.py:1

Use f-string instead of .format() for consistency with the rest of the codebase. Change to err_content = f\"Watchdog - {f.read().replace('\\n', '')}\"
src/ansys/fluent/core/module_config.py:1
The FIXME comment should clarify the intended resolution. Consider adding a TODO for when Python 3.10 support is dropped, or wrap this in a version check to use the proper method when available.
src/ansys/fluent/core/session_utilities.py:1
Add a comment explaining why this pyright directive is needed. This helps maintainers understand the intent and whether it can be removed in the future.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

examples/00-fluent/DOE_ML.py

Copilot

Pull request overview

Copilot reviewed 92 out of 94 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (3)

src/ansys/fluent/core/launcher/slurm_launcher.py:578

SlurmLauncher.__init__ updates ui_mode to GUI when config.show_fluent_gui is enabled, but this happens after _get_argvals_and_session(argvals) has already computed derived values (e.g., graphics_driver) using the pre-override ui_mode. Set ui_mode before calling _get_argvals_and_session, or recompute the derived fields after overriding ui_mode to avoid mismatched launcher configuration.
src/ansys/fluent/core/services/_protocols.py:38
ServiceProtocol currently declares an __init__(channel, metadata) signature. Many service classes in this PR require additional constructor parameters (e.g., fluent_error_state), and FluentConnection.create_grpc_service() explicitly forwards *args. This makes the protocol too strict and can cause type-checking failures/incompatibilities. Update the protocol to accept *args: Any, **kwargs: Any (or model the callable/factory differently) so services with additional required parameters still conform.
src/ansys/fluent/core/fluent_connection.py:756
create_grpc_service() is typed as taking service: type[S] where S is bound to ServiceProtocol, but it always calls service(self._channel, self._metadata, *args). With the current ServiceProtocol constructor type, this call is not type-safe and will be rejected by type checkers for any service needing extra args. Consider loosening the bound (e.g., a Protocol with __init__(channel, metadata, *args, **kwargs)) or changing the generic to reflect the forwarded arguments.

    def create_grpc_service(self, service: type[S], *args) -> S:
        """Create a gRPC service.

        Parameters
        ----------
        service : Any
            service class
        args : Any, optional
            additional arguments, by default empty

        Returns
        -------
        Any
            service object
        """
        return service(self._channel, self._metadata, *args)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/ci.yml

examples/00-fluent/DOE_ML.py

Copilot · 2026-02-17T15:27:23Z

src/ansys/fluent/core/launcher/standalone_launcher.py

+        self.argvals, self.new_session = _get_argvals_and_session(kwargs)
+        self.file_transfer_service = kwargs.get("file_transfer_service")
        if pyfluent.config.show_fluent_gui:
-            ui_mode = UIMode.GUI
-        self.argvals["ui_mode"] = UIMode(ui_mode)
-        if self.argvals["start_timeout"] is None:
+            kwargs["ui_mode"] = UIMode.GUI
+        self.argvals["ui_mode"] = UIMode(kwargs.get("ui_mode"))


In StandaloneLauncher.__init__, ui_mode is overridden when config.show_fluent_gui is set after calling _get_argvals_and_session(kwargs). That helper computes derived values (notably graphics_driver) based on the original ui_mode, so this ordering can leave graphics_driver inconsistent with the final GUI mode. Move the show_fluent_gui override so kwargs['ui_mode'] is set before _get_argvals_and_session, or recompute the dependent fields afterward.

Copilot

Pull request overview

Copilot reviewed 92 out of 94 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/ansys/fluent/core/launcher/launcher.py

pyproject.toml

src/ansys/fluent/core/__init__.py

Copilot · 2026-02-17T15:58:27Z

src/ansys/fluent/core/module_config.py

+        for (
+            k,
+            v,
+        ) in cast(
+            list[tuple[str, Any]],
+            inspect.getmembers_static(  # pyright: ignore[reportAttributeAccessIssue]
+                self
+            ),
+        ):
+            # FIXME: This is an actual bug due to not being in 3.10 (added in 3.11)


The inspect.getmembers_static method was added in Python 3.11. Since this code uses a cast and includes a FIXME comment indicating this is a bug, the code will fail on Python 3.10 and earlier. Either remove this functionality for older Python versions, add a version check with a fallback, or update the minimum Python version requirement.

src/ansys/fluent/core/services/solution_variables.py

src/ansys/fluent/core/services/field_data.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 93 out of 95 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-18T10:38:14Z

src/ansys/fluent/core/launcher/launcher.py

    :class:`~ansys.fluent.core.session_solver.Solver`, \
-    :class:`~ansys.fluent.core.session_solver_icing.SolverIcing`, dict]
+    :class:`~ansys.fluent.core.session_solver_icing.SolverIcing`, tuple[str, str]]
        Session object or configuration dictionary if ``dry_run = True``.


The launch_fluent function has default values for dimension and precision but these should match the docstring and typical usage. The defaults are set to Dimension.THREE and Precision.DOUBLE, which matches issue #4490's goal of providing informative defaults instead of None. However, the function signature shows these defaults are provided, but the docstring in the Returns section still mentions "configuration dictionary if dry_run = True" when it should say "tuple[str, str] if dry_run = True" to match the new type annotation.

Suggested change

Session object or configuration dictionary if ``dry_run = True``.

Session object or tuple[str, str] if ``dry_run = True``.

Gobot1234 and others added 10 commits November 5, 2025 10:21

Add type level support for passing Path instances to download_file

4f2c990

Add typing_extensions

1ddf8e8

Fix inheritance for Meshing

7825ff4

Fix create_launcher allowing None

90d69a0

Update launchers typing to be more specific

654deb4

Fix ci

ec258c3

Fix ci again

00c3a85

remove accidental commits

b6d2e3e

run pyupgrade for moving typing to builtins and a couple of other things

0a48f90

fix some np.arrays that are meant to be ndarrays in types

7b36a1c

Gobot1234 commented Dec 18, 2025

View reviewed changes

mkundu1 mentioned this pull request Dec 30, 2025

100% type hints in PyFluent code #4738

Open

Gobot1234 added 5 commits January 5, 2026 16:50

pre-fix the conflict that will happen

c04b413

add types for services

08e5525

Merge branch 'jhilton/typing-improvements' of https://github.com/ansy…

7c2e9c3

…s/pyfluent into jhilton/typing-improvements

fix some low hanging fruit

0acf4ea

Merge remote-tracking branch 'origin/main' into jhilton/typing-improv…

e6a7bf9

…ements

github-actions bot added documentation Documentation related (improving, adding, etc) examples Publishing PyFluent examples maintenance General maintenance of the repo (libraries, cicd, etc) dependencies Related to dependencies labels Jan 15, 2026

Gobot1234 commented Jan 15, 2026

View reviewed changes

src/ansys/fluent/core/launcher/slurm_launcher.py Outdated Show resolved Hide resolved

Gobot1234 marked this pull request as ready for review January 15, 2026 03:19

Gobot1234 requested review from hpohekar, mkundu1, prmukherj and seanpearsonuk as code owners January 15, 2026 03:19

Copilot AI review requested due to automatic review settings January 15, 2026 03:19

Gobot1234 requested a review from mayankansys as a code owner January 15, 2026 03:19

chore: adding changelog file 4761.added.md [dependabot-skip]

61b6806

Gobot1234 mentioned this pull request Feb 17, 2026

fix: Replace np.in1d with np.isin #4769

Merged

Gobot1234 added 2 commits February 17, 2026 14:13

hopefully fix all the other issues

4c1cb41

Merge branch 'jhilton/typing-improvements' of https://github.com/ansy…

3ac6141

…s/pyfluent into jhilton/typing-improvements

Copilot AI review requested due to automatic review settings February 17, 2026 14:13

Copilot started reviewing on behalf of Gobot1234 February 17, 2026 14:14 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Gobot1234 added 2 commits February 17, 2026 14:20

Merge branch 'main' into jhilton/typing-improvements

d5596c6

fix ci

ba011d9

Copilot AI review requested due to automatic review settings February 17, 2026 14:21

Copilot AI reviewed Feb 17, 2026

View reviewed changes

examples/00-fluent/DOE_ML.py Outdated Show resolved Hide resolved

Gobot1234 added 2 commits February 17, 2026 14:44

okay for real this time

6e8cd22

I hope this fixes it

b0aa392

Copilot AI review requested due to automatic review settings February 17, 2026 15:21

Copilot started reviewing on behalf of Gobot1234 February 17, 2026 15:22 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

more errors

83c443d

Gobot1234 disabled auto-merge February 17, 2026 15:54

Gobot1234 enabled auto-merge (squash) February 17, 2026 15:54

fix the typing only symbol

bc787f1

Copilot AI review requested due to automatic review settings February 17, 2026 15:55

Copilot started reviewing on behalf of Gobot1234 February 17, 2026 15:56 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Gobot1234 requested a review from seanpearsonuk February 17, 2026 16:21

Gobot1234 and others added 2 commits February 18, 2026 01:47

Update slightly silly test

2de9fc2

Update examples/00-fluent/DOE_ML.py

c8e8999

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 18, 2026 10:35

Update examples/00-fluent/DOE_ML.py

9517350

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of Gobot1234 February 18, 2026 10:36 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

	Session object or configuration dictionary if ``dry_run = True``.
	Session object or tuple[str, str] if ``dry_run = True``.

Comments

Conversation

Gobot1234 commented Dec 18, 2025

Context

Change Summary

Uh oh!

Gobot1234 Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Gobot1234 commented Dec 18, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants