-
Notifications
You must be signed in to change notification settings - Fork 0
Add a progress callback to the wait operation function #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
- Coverage 84.47% 82.77% -1.70%
==========================================
Files 19 19
Lines 1217 1225 +8
==========================================
- Hits 1028 1014 -14
- Misses 189 211 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@saimanikant I picked up these changes in this pyhps branch and it worked well https://github.com/ansys/pyhps/pull/595/files Something I've noticed while doing so:
|
Decreased the file size to 1 and file count to 1 - takes 6 seconds to upload the file now. The latest commit also takes care of deleting the temp_file. Thanks |
Pull Request Template
Description
Addressing #86
Added tests.
Checklist
Please complete the following checklist before submitting your pull request: