Skip to content

Add a progress callback to the wait operation function #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 28, 2025
Merged

Conversation

saimanikant
Copy link
Collaborator

Pull Request Template

Description

Addressing #86
Added tests.

Checklist

Please complete the following checklist before submitting your pull request:

  • I have tested these changes locally and verified that they work as intended.
  • I have updated any documentation as needed to reflect these changes (if appropriate)
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.
  • Unit tests have been added (if appropriate)
  • Test-cases have been added (if appropriate)
  • Testing instructions have been added (if appropriate)

@saimanikant saimanikant linked an issue Apr 2, 2025 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.77%. Comparing base (d5487b0) to head (1c11e9c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
- Coverage   84.47%   82.77%   -1.70%     
==========================================
  Files          19       19              
  Lines        1217     1225       +8     
==========================================
- Hits         1028     1014      -14     
- Misses        189      211      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FedericoNegri
Copy link
Collaborator

@saimanikant I picked up these changes in this pyhps branch and it worked well https://github.com/ansys/pyhps/pull/595/files

Something I've noticed while doing so:

  • The conditions on self.client.binary_config.debug and progress_handler need to be adjusted in the async api as well
  • The tests seem to create some very large files (5GB) and eventually take some time to run. Can we make sure (a) we really need that large files (b) we delete them (in the temp dir but also in the dt service!) at the end of the run.

@saimanikant
Copy link
Collaborator Author

  • ntually take some time to run. Can we make sure (a) we really need that large files (b) we delete them (in the temp dir but also in the dt service!) at the end of the run.

Decreased the file size to 1 and file count to 1 - takes 6 seconds to upload the file now. The latest commit also takes care of deleting the temp_file. Thanks

@saimanikant saimanikant merged commit 42d55cf into main May 28, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a progress callback to the wait operation functions
3 participants