-
Notifications
You must be signed in to change notification settings - Fork 132
feat: session
submodule
#3895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/main_commands
Are you sure you want to change the base?
feat: session
submodule
#3895
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis pull request implements the Updated Class Diagram for RunControlsclassDiagram
class RunControls {
+keyw(**kwargs)
+slashexit(slab: str, fname: str, ext: str, **kwargs)
+pause(**kwargs)
+uis(label: str, value: int | str, **kwargs)
+ui(func: str, type_: str, format_: str, screen: str, color: str, krev: str, orient: str, compress: str, quality: str, **kwargs)
+unpause(**kwargs)
+mstart(label: str, key: str, **kwargs)
+memm(lab: str, kywrd: str, **kwargs)
+menu(key: str, **kwargs)
+nerr(nmerr: str, nmabt: str, ifkey: str, num: int | str, **kwargs)
+output(fname: str, ext: str, loc: str, **kwargs)
+input(fname: str, ext: str, dir_: str, line: str, log: int | str, **kwargs)
+cwd(dirpath: str, **kwargs)
+config(lab: str, val: str, **kwargs)
+sys(string: str, **kwargs)
+syp(string: str, arg1: str, arg2: str, arg3: str, arg4: str, arg5: str, arg6: str, arg7: str, arg8: str, **kwargs)
+slashstatus(lab: str, **kwargs)
+filname(fname: str, key: str, **kwargs)
}
note for RunControls "Methods updated with auto-generated code from pyconverter-xml2py. Docstrings and signatures standardized."
Updated Class Diagram for ProcessorEntryclassDiagram
class ProcessorEntry {
+post26(**kwargs)
+post1(**kwargs)
+prep7(**kwargs)
+quit(**kwargs)
+slashsolu(**kwargs)
+finish(**kwargs)
}
note for ProcessorEntry "Methods updated with auto-generated code. Methods aux2, aux3, aux12, aux15 are no longer part of this class."
Updated Class Diagram for ListControlsclassDiagram
class ListControls {
+golist(**kwargs)
+gopr(**kwargs)
+slashgo(**kwargs)
+nopr(**kwargs)
+nolist(**kwargs)
+com(comment: str, **kwargs)
}
note for ListControls "Methods updated with auto-generated code from pyconverter-xml2py. Method slashgo added. Docstrings and signatures standardized."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor changes.
Notes | ||
----- | ||
|
||
.. _s-NOPR_notes: | ||
|
||
Suppresses printout of interpreted input data, including information labeled as "Notes." When this | ||
printout is not suppressed, the data input to the analysis is echoed to the output file in an | ||
expanded format. Printout is suppressed until a :ref:`gopr` or :ref:`slashgo` command is read. | ||
|
||
Use of :ref:`nopr` is not recommended when the graphical user interface (GUI) is active. The GUI | ||
sometimes issues "hidden" :ref:`nopr` and :ref:`gopr` command sequences, which will countermand | ||
user-issued :ref:`nopr` commands, thus making the use of :ref:`nopr` in the GUI environment | ||
unpredictable. | ||
|
||
This command is valid in any processor. | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add here also a warning mentioning that PyMAPDL requirest these printouts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can add a warning (or a note depending of what you prefer) at the top of this function description. Could you specify what you expect in it please?
Latest attempts are intended to fix the pytest errors. |
…feat/session_submodule
… to use `run` since the `abort` argument is not public.
… in instead of the original class.
@clatapie I just fixed the CICD pipeline. The SKIP=mypy git commit -m "feat: my commit message" |
Thank you very much @germa89! |
All the comments have been addressed. |
I need @germa89's feedback on #3895 (comment) before merging this PR. Once I will add the adequate warning, the PR will be ready to merge on my side. |
Description
This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.
This PR focus on the
session
submodule.You can check the mapdl-cmd-conv documentation to have a look at the output of each submodules.
Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.
Issue linked
This PR is meant to be merged within the feat/main_commands branch. The latter will gather all the submodule changes, one by one, prior to be merged to the main branch.
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Implement the
post26
submodule for PyMAPDL, following the PyConverter-XML2Py integration plan to automate documentation generationNew Features:
post26
submodule with comprehensive command implementationsChores:
post26_
directorySummary by Sourcery
Implement the
session
submodule for PyMAPDL, following the PyConverter-XML2Py integration plan to automate documentation generationNew Features:
Enhancements:
Documentation: