-
Notifications
You must be signed in to change notification settings - Fork 132
fix: update Dockerfiles and docker-compose files to use v25.2-ubuntu-cicd and streamline environment variables #3962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cicd and streamline environment variables
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideThis PR upgrades all devcontainer definitions to use the v25.2-ubuntu-cicd base image and streamlines environment variable handling by removing redundant vars from docker-compose files and centralizing them in the Dockerfiles. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Hardcoding the v25.2-ubuntu-cicd tag in multiple Dockerfiles will require manual updates on future version bumps—consider using a build ARG or shared base Dockerfile to centralize the image version.
- You’ve removed ON_STUDENT and ON_UBUNTU flags from docker-compose but added ON_CI/ON_LOCAL in Dockerfiles; double-check that any student- or Ubuntu-specific logic elsewhere still behaves correctly without those flags.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@pyansys-ci-bot LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
As the title.
Issue linked
NA
Checklist
draft
if it is not ready to be reviewed yet.feat: adding new MAPDL command
)Summary by Sourcery
Update container configurations to use the latest v25.2-ubuntu-cicd image and simplify environment variable management
Enhancements:
Build: