Wait for MotorCAD process to quit correctly on Linux - #805
Open
jmacleod-ansys wants to merge 41 commits into
Open
Wait for MotorCAD process to quit correctly on Linux#805jmacleod-ansys wants to merge 41 commits into
jmacleod-ansys wants to merge 41 commits into
Conversation
…rCAD from automation.
…rcad into linux_compatibility
# Conflicts: # pyproject.toml # tests/test_variables.py
…ess because the MC pymotocad process was exiting before the actual MotorCAD instance.
# Conflicts: # tests/test_general.py
…h second for a max of 60 seconds, before giving a warning and forcing kill.
…ie until wait is called.
# Conflicts: # tests/test_thermal.py
# Conflicts: # src/ansys/motorcad/core/rpc_client_core.py # tests/test_geometry.py
added 5 commits
August 13, 2026 15:08
…ss has actually quit before exiting. This is more of an issue on Linux where it can become a zombie if wait is not called.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (54.54%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
- Coverage 88.74% 87.25% -1.49%
==========================================
Files 27 27
Lines 4113 4206 +93
==========================================
+ Hits 3650 3670 +20
- Misses 463 536 +73 🚀 New features to boost your workflow:
|
added 3 commits
August 14, 2026 15:03
…alled on processes that have already quit, resulting in send_and_recieve failing because there is no connection.
jmacleod-ansys
marked this pull request as ready for review
August 17, 2026 07:46
jmacleod-ansys
requested review from
JackB-Ansys,
james-packer,
jgsdavies,
matthewAnsys and
ravi-ansys
as code owners
August 17, 2026 07:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add code to improve handling of quit and make sure the MotorCAD process has actually quit before exiting. This is more of an issue on Linux where it can become a zombie if wait is not called.