Conversation
📝 WalkthroughWalkthrough为 charts 与 graphs 两个包新增版本变更日志(charts: 2.6.2;graphs: 2.1.1),并在各自的 package.json 进行版本号提升。此变更仅涉及文档与元数据,未包含源码或导出 API 的修改。 Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Summary of Changes
Hello @yvonneyx, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating the versions of the @ant-design/charts and @ant-design/graphs packages. It bumps the charts package to version 2.6.2 and the graphs package to 2.1.1. The updates include a collection of bug fixes that improve rendering, data handling, and performance, along with the introduction of a new scale processing feature for both libraries. The changes are reflected in the respective package.json and CHANGELOG.md files for each package.
Highlights
- Charts Package Version Update: The
@ant-design/chartspackage has been updated to version2.6.2. This update includes several bug fixes and a new feature related to scale processing. - Graphs Package Version Update: The
@ant-design/graphspackage has been updated to version2.1.1. Similar to the charts package, this update incorporates various bug fixes and the same new scale processing feature. - Bug Fixes Across Packages: Both packages received updates addressing issues such as abnormal chart rendering, empty data handling for lineY, memory overflow, and optimized node processing.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the version for the charts and graphs packages. My review focuses on the correctness of the CHANGELOG.md files. I've found that both changelogs have issues: incorrect comparison URLs and duplicated or irrelevant entries. I've provided suggestions to fix these to ensure the changelogs are accurate and clear.
| ## [2.6.2](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.6.2) (2025-08-14) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * 修复 ice 产物 react 匹配错误 ([#3017](https://github.com/ant-design/ant-design-charts/issues/3017)) ([eb2cb95](https://github.com/ant-design/ant-design-charts/commit/eb2cb95e06c07e32ad1e22a5f2bfdab29f3eafad)) | ||
| * chart render abnormal due to the scale ([#3029](https://github.com/ant-design/ant-design-charts/issues/3029)) ([21a27e9](https://github.com/ant-design/ant-design-charts/commit/21a27e9014a51e0cd3342ac713f24f583718017e)) | ||
| * Fix the issue where lineY cannot be drawn when data is empty ([#3013](https://github.com/ant-design/ant-design-charts/issues/3013)) ([3819d71](https://github.com/ant-design/ant-design-charts/commit/3819d71967f23170117d4cbb20fa77d7e8756f65)) | ||
| * **graphs:** 优化 CollapseExpandReactNode 中节点处理逻辑,移除不必要的节点查找 ([#3045](https://github.com/ant-design/ant-design-charts/issues/3045)) ([328ed45](https://github.com/ant-design/ant-design-charts/commit/328ed4529cbd547df8c1e4c6ff9e559ec98de00a)) | ||
| * memory overflow by event emitter ([#3018](https://github.com/ant-design/ant-design-charts/issues/3018)) ([02b92c5](https://github.com/ant-design/ant-design-charts/commit/02b92c5a053cd4cb91e4073044280f6b55f0189f)) | ||
| * reset example is abnormal ([#3014](https://github.com/ant-design/ant-design-charts/issues/3014)) ([22b833e](https://github.com/ant-design/ant-design-charts/commit/22b833e6cdc65a61e1c85369359e6aee84a943b0)) | ||
| * the abnormal jsx detection in the BigFish4 dev environment ([#3030](https://github.com/ant-design/ant-design-charts/issues/3030)) ([881a648](https://github.com/ant-design/ant-design-charts/commit/881a648141bb661a4933a3d2ceb5a6c59885aa65)) | ||
|
|
||
|
|
||
| ### Features | ||
|
|
||
| * add a scale processing ([#3021](https://github.com/ant-design/ant-design-charts/issues/3021)) ([fc46dd7](https://github.com/ant-design/ant-design-charts/commit/fc46dd7c1ac8dfc618605e5dc5e4326f93f8b912)) |
There was a problem hiding this comment.
The changelog for version 2.6.2 appears to have a few issues:
- The comparison link for version
2.6.2points to2.6.0...2.6.2, which includes changes from2.6.1. It should likely compare against the previous version,2.6.1...2.6.2. - Several bug fixes listed under
2.6.2were already included in the2.6.1release, which can be misleading. A new version's changelog should only list new changes. - There are extra newlines that affect readability.
I've prepared a suggestion to correct the version comparison link, remove duplicate entries, and clean up the formatting.
| ## [2.6.2](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.6.2) (2025-08-14) | |
| ### Bug Fixes | |
| * 修复 ice 产物 react 匹配错误 ([#3017](https://github.com/ant-design/ant-design-charts/issues/3017)) ([eb2cb95](https://github.com/ant-design/ant-design-charts/commit/eb2cb95e06c07e32ad1e22a5f2bfdab29f3eafad)) | |
| * chart render abnormal due to the scale ([#3029](https://github.com/ant-design/ant-design-charts/issues/3029)) ([21a27e9](https://github.com/ant-design/ant-design-charts/commit/21a27e9014a51e0cd3342ac713f24f583718017e)) | |
| * Fix the issue where lineY cannot be drawn when data is empty ([#3013](https://github.com/ant-design/ant-design-charts/issues/3013)) ([3819d71](https://github.com/ant-design/ant-design-charts/commit/3819d71967f23170117d4cbb20fa77d7e8756f65)) | |
| * **graphs:** 优化 CollapseExpandReactNode 中节点处理逻辑,移除不必要的节点查找 ([#3045](https://github.com/ant-design/ant-design-charts/issues/3045)) ([328ed45](https://github.com/ant-design/ant-design-charts/commit/328ed4529cbd547df8c1e4c6ff9e559ec98de00a)) | |
| * memory overflow by event emitter ([#3018](https://github.com/ant-design/ant-design-charts/issues/3018)) ([02b92c5](https://github.com/ant-design/ant-design-charts/commit/02b92c5a053cd4cb91e4073044280f6b55f0189f)) | |
| * reset example is abnormal ([#3014](https://github.com/ant-design/ant-design-charts/issues/3014)) ([22b833e](https://github.com/ant-design/ant-design-charts/commit/22b833e6cdc65a61e1c85369359e6aee84a943b0)) | |
| * the abnormal jsx detection in the BigFish4 dev environment ([#3030](https://github.com/ant-design/ant-design-charts/issues/3030)) ([881a648](https://github.com/ant-design/ant-design-charts/commit/881a648141bb661a4933a3d2ceb5a6c59885aa65)) | |
| ### Features | |
| * add a scale processing ([#3021](https://github.com/ant-design/ant-design-charts/issues/3021)) ([fc46dd7](https://github.com/ant-design/ant-design-charts/commit/fc46dd7c1ac8dfc618605e5dc5e4326f93f8b912)) | |
| ## [2.6.2](https://github.com/ant-design/ant-design-charts/compare/2.6.1...2.6.2) (2025-08-14) | |
| ### Bug Fixes | |
| * chart render abnormal due to the scale ([#3029](https://github.com/ant-design/ant-design-charts/issues/3029)) ([21a27e9](https://github.com/ant-design/ant-design-charts/commit/21a27e9014a51e0cd3342ac713f24f583718017e)) | |
| * **graphs:** 优化 CollapseExpandReactNode 中节点处理逻辑,移除不必要的节点查找 ([#3045](https://github.com/ant-design/ant-design-charts/issues/3045)) ([328ed45](https://github.com/ant-design/ant-design-charts/commit/328ed4529cbd547df8c1e4c6ff9e559ec98de00a)) | |
| * the abnormal jsx detection in the BigFish4 dev environment ([#3030](https://github.com/ant-design/ant-design-charts/issues/3030)) ([881a648](https://github.com/ant-design/ant-design-charts/commit/881a648141bb661a4933a3d2ceb5a6c59885aa65)) | |
| ### Features | |
| * add a scale processing ([#3021](https://github.com/ant-design/ant-design-charts/issues/3021)) ([fc46dd7](https://github.com/ant-design/ant-design-charts/commit/fc46dd7c1ac8dfc618605e5dc5e4326f93f8b912)) |
| ## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.1.1) (2025-08-14) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * 修复 ice 产物 react 匹配错误 ([#3017](https://github.com/ant-design/ant-design-charts/issues/3017)) ([eb2cb95](https://github.com/ant-design/ant-design-charts/commit/eb2cb95e06c07e32ad1e22a5f2bfdab29f3eafad)) | ||
| * chart render abnormal due to the scale ([#3029](https://github.com/ant-design/ant-design-charts/issues/3029)) ([21a27e9](https://github.com/ant-design/ant-design-charts/commit/21a27e9014a51e0cd3342ac713f24f583718017e)) | ||
| * Fix the issue where lineY cannot be drawn when data is empty ([#3013](https://github.com/ant-design/ant-design-charts/issues/3013)) ([3819d71](https://github.com/ant-design/ant-design-charts/commit/3819d71967f23170117d4cbb20fa77d7e8756f65)) | ||
| * **graphs:** 优化 CollapseExpandReactNode 中节点处理逻辑,移除不必要的节点查找 ([#3045](https://github.com/ant-design/ant-design-charts/issues/3045)) ([328ed45](https://github.com/ant-design/ant-design-charts/commit/328ed4529cbd547df8c1e4c6ff9e559ec98de00a)) | ||
| * memory overflow by event emitter ([#3018](https://github.com/ant-design/ant-design-charts/issues/3018)) ([02b92c5](https://github.com/ant-design/ant-design-charts/commit/02b92c5a053cd4cb91e4073044280f6b55f0189f)) | ||
| * reset example is abnormal ([#3014](https://github.com/ant-design/ant-design-charts/issues/3014)) ([22b833e](https://github.com/ant-design/ant-design-charts/commit/22b833e6cdc65a61e1c85369359e6aee84a943b0)) | ||
| * the abnormal jsx detection in the BigFish4 dev environment ([#3030](https://github.com/ant-design/ant-design-charts/issues/3030)) ([881a648](https://github.com/ant-design/ant-design-charts/commit/881a648141bb661a4933a3d2ceb5a6c59885aa65)) | ||
|
|
||
|
|
||
| ### Features | ||
|
|
||
| * add a scale processing ([#3021](https://github.com/ant-design/ant-design-charts/issues/3021)) ([fc46dd7](https://github.com/ant-design/ant-design-charts/commit/fc46dd7c1ac8dfc618605e5dc5e4326f93f8b912)) |
There was a problem hiding this comment.
The changelog entry for version 2.1.1 appears to be incorrect.
- The comparison link
.../compare/2.6.0...2.1.1is invalid. It should likely be.../compare/2.1.0...2.1.1to show changes since the last version. - The list of bug fixes and features seems to be a copy from the
@ant-design/chartspackage's changelog. The changelog for@ant-design/graphsshould only contain changes relevant to this specific package. Based on the commit messages, it seems only one bug fix is relevant here.
Here is a suggested correction to ensure the changelog is accurate.
| ## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.1.1) (2025-08-14) | |
| ### Bug Fixes | |
| * 修复 ice 产物 react 匹配错误 ([#3017](https://github.com/ant-design/ant-design-charts/issues/3017)) ([eb2cb95](https://github.com/ant-design/ant-design-charts/commit/eb2cb95e06c07e32ad1e22a5f2bfdab29f3eafad)) | |
| * chart render abnormal due to the scale ([#3029](https://github.com/ant-design/ant-design-charts/issues/3029)) ([21a27e9](https://github.com/ant-design/ant-design-charts/commit/21a27e9014a51e0cd3342ac713f24f583718017e)) | |
| * Fix the issue where lineY cannot be drawn when data is empty ([#3013](https://github.com/ant-design/ant-design-charts/issues/3013)) ([3819d71](https://github.com/ant-design/ant-design-charts/commit/3819d71967f23170117d4cbb20fa77d7e8756f65)) | |
| * **graphs:** 优化 CollapseExpandReactNode 中节点处理逻辑,移除不必要的节点查找 ([#3045](https://github.com/ant-design/ant-design-charts/issues/3045)) ([328ed45](https://github.com/ant-design/ant-design-charts/commit/328ed4529cbd547df8c1e4c6ff9e559ec98de00a)) | |
| * memory overflow by event emitter ([#3018](https://github.com/ant-design/ant-design-charts/issues/3018)) ([02b92c5](https://github.com/ant-design/ant-design-charts/commit/02b92c5a053cd4cb91e4073044280f6b55f0189f)) | |
| * reset example is abnormal ([#3014](https://github.com/ant-design/ant-design-charts/issues/3014)) ([22b833e](https://github.com/ant-design/ant-design-charts/commit/22b833e6cdc65a61e1c85369359e6aee84a943b0)) | |
| * the abnormal jsx detection in the BigFish4 dev environment ([#3030](https://github.com/ant-design/ant-design-charts/issues/3030)) ([881a648](https://github.com/ant-design/ant-design-charts/commit/881a648141bb661a4933a3d2ceb5a6c59885aa65)) | |
| ### Features | |
| * add a scale processing ([#3021](https://github.com/ant-design/ant-design-charts/issues/3021)) ([fc46dd7](https://github.com/ant-design/ant-design-charts/commit/fc46dd7c1ac8dfc618605e5dc5e4326f93f8b912)) | |
| ## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.1.0...2.1.1) (2025-08-14) | |
| ### Bug Fixes | |
| * **graphs:** 优化 CollapseExpandReactNode 中节点处理逻辑,移除不必要的节点查找 ([#3045](https://github.com/ant-design/ant-design-charts/issues/3045)) ([328ed45](https://github.com/ant-design/ant-design-charts/commit/328ed4529cbd547df8c1e4c6ff9e559ec98de00a)) |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/graphs/CHANGELOG.md (2)
6-12: 请确认“Bug Fixes”条目与 graphs 包实际改动范围的一致性此处多条目看起来更偏向 charts 场景(例如 “chart render abnormal due to the scale”),如果是跨包共享修复,请在对应两个包的日志中保留;若仅发生于 charts,建议移出 graphs 的日志以免误导用户。
是否需要我基于提交范围自动比对两包的改动文件路径,辅助归属排查?
17-17: “Features: add a scale processing” 与 Bug Fixes 重复度较高,请确认是否为同一变更的功能/修复双重记录如为同一改动在两处体现,建议在 Feature 或 Fix 之一保留主记录,另一处以简短说明引用,减少重复。
packages/charts/CHANGELOG.md (1)
1-1: compare 区间建议从 2.6.1 对比到 2.6.2当前 compare 为 2.6.0...2.6.2,虽然不影响使用,但语义上更推荐与上一个正式版本对比,便于历史追溯。
可选修正:
-## [2.6.2](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.6.2) (2025-08-14) +## [2.6.2](https://github.com/ant-design/ant-design-charts/compare/2.6.1...2.6.2) (2025-08-14)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
packages/charts/CHANGELOG.md(1 hunks)packages/charts/package.json(1 hunks)packages/graphs/CHANGELOG.md(1 hunks)packages/graphs/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: lint (latest)
- GitHub Check: test (latest)
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: test (latest)
- GitHub Check: lint (latest)
🔇 Additional comments (3)
packages/graphs/package.json (1)
3-3: 确认:graphs 包版本与 CHANGELOG 匹配(2.1.1)已验证 packages/graphs/package.json 中 version 为 2.1.1,packages/graphs/CHANGELOG.md 存在对应条目且 compare 链接以 ...2.1.1 结尾(条目:
## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.1.1) (2025-08-14))。无需进一步修改。
- 已检查文件:
- packages/graphs/package.json (version: 2.1.1)
- packages/graphs/CHANGELOG.md (含对应条目)
packages/charts/package.json (1)
4-4: 确认:charts 版本已正确提升至 2.6.2,变更日志与 workspace 依赖一致已运行校验脚本,结果:
- packages/charts/package.json — version = 2.6.2
- packages/charts/CHANGELOG.md — 存在 "## [2.6.2]" 条目
- packages/charts/package.json — @ant-design/graphs 保持为 "workspace:^"
无需进一步修改,LGTM。
packages/charts/CHANGELOG.md (1)
6-12: 2.6.2 的部分“Bug Fixes”与 2.6.1 中条目重复,请确认是否为重复收录若为重复,建议去重;若为回滚后重发或补充修复,请在条目中标注补充原因,提升可读性。
我可以提供一个脚本对比 2.6.1 与 2.6.2 两段内容并输出重复条目,是否需要?
| @@ -1,3 +1,23 @@ | |||
| ## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.1.1) (2025-08-14) | |||
There was a problem hiding this comment.
compare 链接起始版本错误,应从 2.1.0 对比到 2.1.1
当前为 2.6.0...2.1.1(明显引用了 charts 的版本),应改为 graphs 的上一个版本 2.1.0。
请应用以下修正:
-## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.1.1) (2025-08-14)
+## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.1.0...2.1.1) (2025-08-14)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.6.0...2.1.1) (2025-08-14) | |
| ## [2.1.1](https://github.com/ant-design/ant-design-charts/compare/2.1.0...2.1.1) (2025-08-14) |
🤖 Prompt for AI Agents
packages/graphs/CHANGELOG.md around lines 1 to 1: the compare link incorrectly
uses charts' version range "2.6.0...2.1.1"; change the compare range to use
graphs' previous version so it reads "2.1.0...2.1.1" (i.e., replace "2.6.0" with
"2.1.0") to correctly compare the prior graphs release to this one.
Summary by CodeRabbit