feat: Picker和PickerView组件增加mouseWheel事件支持 #5052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shusiwei
commented
Apr 11, 2022
shusiwei
commented
- Picker和PickerView组件增加mouseWheel属性
- 暴露useLockScroll中的lock&unlock方法
- 中英文文档跟进
Closed
added 4 commits
April 12, 2022 07:07
Codecov Report
@@ Coverage Diff @@
## master #5052 +/- ##
==========================================
+ Coverage 42.23% 44.01% +1.77%
==========================================
Files 277 278 +1
Lines 5760 5782 +22
Branches 1333 1335 +2
==========================================
+ Hits 2433 2545 +112
+ Misses 3101 3025 -76
+ Partials 226 212 -14
Continue to review full report at Codecov.
|
shusiwei
changed the title
Closed
shusiwei
commented
Apr 13, 2022
| @@ -17,6 +17,7 @@ PickerView 是 [Picker](./picker/#picker) 的内容区域。 | |||
| | defaultValue | 默认选中项 | `PickerValue[]` | `[]` | | |||
| | onChange | 选项改变时触发 | `(value: PickerValue[], extend: PickerValueExtend) => void` | - | | |||
| | renderLabel | 自定义渲染每列展示的内容 | `(item: PickerColumnItem) => ReactNode` | `(item) => item.label` | | |||
| | mouseWheel | 鼠标滚轮模式 | `boolean` | `false` | | |||
There was a problem hiding this comment.
一次滚动，直接滚动4条数据了
是的，目前依然有这个问题。不知道何时可以解决呢？
There was a problem hiding this comment.
一次滚动，直接滚动4条数据了
是的，目前依然有这个问题。不知道何时可以解决呢？
我刚才提交了个pr，看会不会合并吧 #6853
shusiwei
commented
Apr 13, 2022
| @@ -17,6 +17,7 @@ PickerView is the content area of [Picker](./picker/#picker). | |||
| | defaultValue | Default selected options | `PickerValue[]` | `[]` | | |||
| | onChange | Triggered when the options are changed | `(value: PickerValue[], extend: PickerValueExtend) => void` | - | | |||
| | renderLabel | The function to custom rendering the label shown on a column | `(item: PickerColumnItem) => ReactNode` | `(item) => item.label` | | |||
| | mouseWheel | Support mouse wheel events | `boolean` | `false` | | |||
There was a problem hiding this comment.
应该修正为 Enable mouse wheel mode
awmleer
approved these changes
Apr 13, 2022
|
在你的基础上改了一下 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.