Skip to content

[Bugfix]Popover.Menu 在深色模式下, 背景颜色错误 #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neil4dong
Copy link

[Bugfix]Popover.Menu 在深色模式下, 背景颜色错误

Copy link
Contributor

github-actions bot commented Mar 20, 2025

Preview is ready

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (d1f4dd4) to head (b1b66eb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6847   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files         335      335           
  Lines        7217     7217           
  Branches     1816     1805   -11     
=======================================
  Hits         6690     6690           
  Misses        491      491           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -3,7 +3,7 @@
.@{class-prefix-popover} {
--z-index: var(--adm-popover-z-index, 1030);

--background: #ffffff;
--background: var(--adm-color-background);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来不太明显:

截屏2025-03-21 02 19 51

Copy link
Author

@neil4dong neil4dong Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实有点不太明显, 不过比原来好。 我看了下应该是要用 shadow-box 来做, 不过我不是前端, 刚刚试了一下没有尝试出好的方法。 我看有一个--adm-color-box 的变量,试了一下不太合适也不是rgba的, 或许需要去定一个一个关于shadow的全局css变量? 有没有什么建议呢

第43行 : box-shadow: 0 0 30px 0 rgba(51, 51, 51, 0.2);

box-shadow: 0 0 30px 0 rgba(51, 51, 51, 0.2);

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants