Skip to content

feat(MultiImageViewer): implement RTL support for MultiImageViewer co… #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SnakeLil
Copy link

Resolved the RTL compatibility issue mentioned in
https://github.com/ant-design/ant-design-mobile/issues/6727#issuecomment-2603546837

  • Add right-to-left layout compatibility for dir attribute usage
  • Handle mirrored positioning and gesture behavior in RTL mode

Copy link
Contributor

github-actions bot commented Mar 21, 2025

Preview is ready

@zombieJ
Copy link
Member

zombieJ commented Mar 24, 2025

CI failed. pls check

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.68%. Comparing base (d1f4dd4) to head (8b0bb36).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/get-is-rtl.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6848      +/-   ##
==========================================
- Coverage   92.69%   92.68%   -0.02%     
==========================================
  Files         335      336       +1     
  Lines        7217     7227      +10     
  Branches     1816     1825       +9     
==========================================
+ Hits         6690     6698       +8     
- Misses        491      493       +2     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants