-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat(TextArea): add clearable functionality to TextArea component (#7021) #7022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
viko16
wants to merge
13
commits into
ant-design:master
Choose a base branch
from
viko16:feature/textarea-clearable
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d76c2dc
feat(TextArea): add clearable functionality to TextArea component
viko16 bae8a1b
fix(locale): unify clear button translations for Input and TextArea
viko16 211b388
test(TextArea): enhance tests for clear button behavior on iOS and no…
viko16 1674b77
refactor(TextArea): remove defaultProps assignment
viko16 5f25903
style(TextArea): enhance layout and structure for better responsiveness
viko16 bedef31
test(TextArea): update snapshot for improved component structure
viko16 413944a
feat(TextArea): show clear button only when focused
viko16 48a98a8
docs(TextArea): clarify clear button display condition in documentation
viko16 c68e12d
refactor(text-area): merge onClear and clearIcon into clearable prop
viko16 5dfe296
refactor(text-area): extract clearable logic into useClearable hook
viko16 d4760e3
fix(hooks): default shouldShowClear to require focus in useClearable
viko16 8058a86
refactor(TextArea): flatten DOM and extract clear icon padding as CSS…
viko16 f83c482
test(text-area): add unit test for clear button mouseDown preventDefault
viko16 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.