feat(cascader): 添加弹出层圆角样式#7050
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough为 Cascader 的底部弹层 Popup 增加了弹层主体类名绑定,并在组件样式中为该类添加顶部左右圆角(使用 CSS 变量 ChangesCascader 弹层圆角样式
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request adds rounded top corners to the Cascader component's popup body by introducing a new class and specific CSS rules. The reviewer suggests using the bodyClassName property on the Popup component instead of a general class, which would allow for more direct styling of the popup body and avoid the use of nested selectors, thereby improving maintainability.
|
|
||
| const popupElement = ( | ||
| <Popup | ||
| className={`${classPrefix}-popup`} |
| .@{class-prefix-picker}-popup { | ||
| & .adm-popup-body { | ||
| border-top-left-radius: var(--adm-radius-m); | ||
| border-top-right-radius: var(--adm-radius-m); | ||
| } | ||
| } |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7050 +/- ##
=======================================
Coverage 92.94% 92.94%
=======================================
Files 337 337
Lines 7386 7386
Branches 1868 1879 +11
=======================================
Hits 6865 6865
Misses 485 485
Partials 36 36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
close #6432
Summary by CodeRabbit