-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated deps #11423
base: master
Are you sure you want to change the base?
Conversation
概述演练这个拉取请求涉及对 变更
诗歌
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected], npm/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/RightContent/AvatarDropdown.tsx (1)
57-57
: 代码逻辑正确,建议添加注释!使用
searchParams.toString()
生成查询字符串的实现是正确的。建议添加简短注释说明此处的转换目的。+ // 将 URLSearchParams 对象转换为查询字符串 search: searchParams.toString(),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
package.json
(0 hunks)src/components/RightContent/AvatarDropdown.tsx
(1 hunks)
💤 Files with no reviewable changes (1)
- package.json
🔇 Additional comments (1)
src/components/RightContent/AvatarDropdown.tsx (1)
48-50
: 很好的现代化重构!使用
URLSearchParams
替代querystring.stringify
是个很好的改进。这种方式不仅移除了过时的依赖,而且使用了更现代的 Web API。
您好,我是刘学炜,谢谢您的邮件,我会尽快查收并回复。祝您生活愉快
|
WARN deprecated @types/[email protected]: This is a stub types definition. classnames provides its own type definitions, so you do not need this installed.
WARN deprecated @types/[email protected]: This is a stub types definition. history provides its own type definitions, so you do not need this installed.
WARN deprecated [email protected]: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
Summary by CodeRabbit
依赖项更改
querystring
依赖@types/classnames
开发依赖@types/history
开发依赖功能调整
URLSearchParams
替代querystring
处理重定向参数