fix(solana): add support for Mobile Wallet Adapter in config provider #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 59637ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1368 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 864 864
Lines 18491 18519 +28
Branches 1649 1657 +8
=========================================
+ Hits 18491 18519 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.changeset/tricky-rockets-build.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@ant-design/web3-solana': patch | |||
There was a problem hiding this comment.
solana 这个包算是新增功能，应该是一个 minor
| const autoRegisteredWallets = wallets | ||
| .filter((w) => !providedWalletNames.includes(w.adapter.name)) | ||
| .map<Wallet>((w) => { | ||
| const adapter = w.adapter; | ||
|
|
||
| // MWA is a special case, it's always ready | ||
| if (adapter.name === MWA_WALLET_NAME) { |
There was a problem hiding this comment.
除了 name，还有更可靠的判断方法吗？
| @@ -228,6 +246,12 @@ export const AntDesignWeb3ConfigProvider: React.FC< | |||
| selectWallet(currentWalletName); | |||
| }} | |||
| connect={async (_wallet, options) => { | |||
| // if the wallet is MWA, just call `connect`, it will pop up the mobile wallet immediately | |||
| if (_wallet?.name === MWA_WALLET_NAME) { | |||
| _wallet._standardWallet?.connect(); | |||
There was a problem hiding this comment.
这个背后实现的逻辑是什么？是基于什么协议实现的？是会打开第三方 app 吗？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Background and solution
🔗 Related issue link
fix #1367