-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: cache effect #218
perf: cache effect #218
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎊 PR Preview a597361 has been successfully built and deployed to https://ant-design-cssinjs-preview-pr-218.surge.sh 🕐 Build time: 89.916s 🤖 By surge-preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #218 +/- ##
==========================================
+ Coverage 94.50% 94.52% +0.02%
==========================================
Files 31 31
Lines 2749 2760 +11
Branches 433 435 +2
==========================================
+ Hits 2598 2609 +11
Misses 151 151 ☔ View full report in Codecov by Sentry. |
Benchmark
同时渲染 40000 个 Button,同一个组件,共用一份样式。
效果
benchmark 比较极端,正常不太会这么写页面,但可以看出能节省很多时间。
原理
在之前的逻辑里每个 Button 渲染的时候都会执行
updateCSS
,这个方法会在 document 里遍历 style 标签。现在做了一个缓存 Map,同一份样式在一个微任务期间只会执行一次
updateCSS
。