feat: extract style node to support Next.js _document.tsx render style tags #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo837
reviewed
Jan 13, 2023
| @@ -483,3 +483,25 @@ export function extractStyle(cache: Cache) { | |||
|
|
|||
| return styleText; | |||
| } | |||
|
|
|||
| export function extractStyleNode(cache: Cache) { | |||
There was a problem hiding this comment.
逻辑是不是可以合并到 extractStyle 一起?
There was a problem hiding this comment.
一开始我是想放一起的，直接让extraStyle 返回一个对象，让用户想获取那个就哪个，但是怕对用户来说有break change,所以重启炉灶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next.js ssr分离style时不允许直接使用extractStyle中提供的string类型的styles, 需要以react elements的形式定义。目前存在的都是hack写法：例如ant-design/ant-design#38767 (comment)
rel: ant-design/ant-design#39891 、ant-design/ant-design#39885
在Next.js中可以这么使用
