Skip to content

fix: 修复 Skill 组件 Tooltip 子元素必须为 React 元素的问题 #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chiaki-xps wants to merge 1 commit into from
+7 −1
Closed

fix: 修复 Skill 组件 Tooltip 子元素必须为 React 元素的问题 #1533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/x/components/sender/components/Skill.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,13 @@ const Skill: React.FC<SkillProps> = ({
}, [closable, removeSkill]);

const mergeTitle = title || value;
const titleNode = toolTip ? <Tooltip {...toolTip}>{mergeTitle}</Tooltip> : mergeTitle;
const titleNode = toolTip ? (
<Tooltip {...toolTip}>
<span>{mergeTitle}</span>
Copy link
Member

@afc163 afc163 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

antd 版本是啥，按道理 Tooltip 会自动处理这种情况。

Copy link
Contributor Author

@Chiaki-xps Chiaki-xps Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前的main分支跑测试用例的时候出现这个问题

Copy link
Contributor Author

@Chiaki-xps Chiaki-xps Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当前x的antd是6.1。我看看antd是不是又这个问题

Copy link
Collaborator

@kimteayon kimteayon Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在应该不会有这个问题 之前有这个问题是因为 @ant-design/tools 没升级 本地合并下 main 重新安装依赖跑下就好了

</Tooltip>
) : (
mergeTitle
);

return (
<div className={`${componentCls}-wrapper`} contentEditable={false}>
Expand Down
Loading