Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve dual scrollbar issue and flickering on initial load #485

Merged
merged 7 commits into from
Mar 10, 2025
+115 −106
Merged

Fix: Resolve dual scrollbar issue and flickering on initial load #485

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
28c02ec
Fix: Resolve dual scrollbar issue and flickering on initial load
LofiSu Jan 18, 2025
697a76f
Merge branch 'main' into main
YumoImer Jan 21, 2025
492191f
fix: add snapshot
LofiSu Jan 23, 2025
16c3a6a
Merge branch 'main' into main
YumoImer Jan 24, 2025
c31072f
Merge branch 'main' into main
kimteayon Mar 7, 2025
ce7f7c4
Merge branch 'main' into main
afc163 Mar 9, 2025
d59678a
Merge branch 'main' into main
kimteayon Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: add snapshot
@LofiSu
LofiSu committed Jan 23, 2025
commit 492191f5fdc12d34717cd1043504fb8fc9313f3f
9 changes: 5 additions & 4 deletions components/attachments/__tests__/__snapshots__/demo-extend.test.ts.snap
View file
Original file line number Diff line number Diff line change
@@ -747,8 +747,9 @@ exports[`renders components/attachments/demo/overflow.tsx extend context correct
<div
aria-label="segmented control"
class="ant-segmented"
role="listbox"
role="radiogroup"
style="margin-inline-end: auto;"
tabindex="0"
>
<div
class="ant-segmented-group"
@@ -759,12 +760,12 @@ exports[`renders components/attachments/demo/overflow.tsx extend context correct
<input
checked=""
class="ant-segmented-item-input"
name="test-id"
type="radio"
/>
<div
aria-selected="true"
class="ant-segmented-item-label"
role="option"
title="Wrap"
>
Wrap
@@ -775,12 +776,12 @@ exports[`renders components/attachments/demo/overflow.tsx extend context correct
>
<input
class="ant-segmented-item-input"
name="test-id"
type="radio"
/>
<div
aria-selected="false"
class="ant-segmented-item-label"
role="option"
title="Scroll X"
>
Scroll X
@@ -791,12 +792,12 @@ exports[`renders components/attachments/demo/overflow.tsx extend context correct
>
<input
class="ant-segmented-item-input"
name="test-id"
type="radio"
/>
<div
aria-selected="false"
class="ant-segmented-item-label"
role="option"
title="Scroll Y"
>
Scroll Y
11 changes: 6 additions & 5 deletions components/attachments/__tests__/__snapshots__/demo.test.tsx.snap
View file
Original file line number Diff line number Diff line change
@@ -677,8 +677,9 @@ Array [
<div
aria-label="segmented control"
class="ant-segmented"
role="listbox"
role="radiogroup"
style="margin-inline-end:auto"
tabindex="0"
>
<div
class="ant-segmented-group"
@@ -689,12 +690,12 @@ Array [
<input
checked=""
class="ant-segmented-item-input"
name="test-id"
type="radio"
/>
<div
aria-selected="true"
class="ant-segmented-item-label"
role="option"
title="Wrap"
>
Wrap
@@ -705,12 +706,12 @@ Array [
>
<input
class="ant-segmented-item-input"
name="test-id"
type="radio"
/>
<div
aria-selected="false"
class="ant-segmented-item-label"
role="option"
title="Scroll X"
>
Scroll X
@@ -721,12 +722,12 @@ Array [
>
<input
class="ant-segmented-item-input"
name="test-id"
type="radio"
/>
<div
aria-selected="false"
class="ant-segmented-item-label"
role="option"
title="Scroll Y"
>
Scroll Y
@@ -1905,7 +1906,7 @@ Array [
exports[`renders components/attachments/demo/placeholder.tsx correctly 1`] = `
<div
class="ant-flex ant-flex-align-stretch ant-flex-gap-middle ant-flex-vertical"
style="padding:16px;background:rgba(0, 0, 0, 0.04)"
style="padding:16px;background:rgba(0,0,0,0.04)"
>
<div
style="border-radius:6px;overflow:hidden;background:#ffffff"
92 changes: 46 additions & 46 deletions components/bubble/__tests__/__snapshots__/demo-extend.test.ts.snap
View file

Large diffs are not rendered by default.

92 changes: 46 additions & 46 deletions components/bubble/__tests__/__snapshots__/demo.test.ts.snap
View file

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions components/conversations/__tests__/__snapshots__/demo-extend.test.ts.snap
View file
Original file line number Diff line number Diff line change
@@ -704,14 +704,14 @@ exports[`renders components/conversations/demo/group-sort.tsx extend context cor
exports[`renders components/conversations/demo/infinite-load.tsx extend context correctly 1`] = `
<div
id="scrollableDiv"
style="width: 280px; height: 600px; background: #ffffff; border-radius: 6px; overflow: scroll;"
style="width: 280px; height: 600px; background: #ffffff; border-radius: 6px; overflow: auto;"
>
<div
class="infinite-scroll-component__outerdiv"
>
<div
class="infinite-scroll-component "
style="height: auto; overflow: auto;"
style="height: auto; overflow: hidden;"
>
<ul
class="ant-conversations"
4 changes: 2 additions & 2 deletions components/conversations/__tests__/__snapshots__/demo.test.ts.snap
View file
Original file line number Diff line number Diff line change
@@ -356,14 +356,14 @@ exports[`renders components/conversations/demo/group-sort.tsx correctly 1`] = `
exports[`renders components/conversations/demo/infinite-load.tsx correctly 1`] = `
<div
id="scrollableDiv"
style="width:280px;height:600px;background:#ffffff;border-radius:6px;overflow:scroll"
style="width:280px;height:600px;background:#ffffff;border-radius:6px;overflow:auto"
>
<div
class="infinite-scroll-component__outerdiv"
>
<div
class="infinite-scroll-component "
style="height:auto;overflow:auto;-webkit-overflow-scrolling:touch"
style="height:auto;overflow:hidden;-webkit-overflow-scrolling:touch"
>
<ul
class="ant-conversations"
118 changes: 59 additions & 59 deletions components/sender/__tests__/__snapshots__/index.test.tsx.snap
View file
Original file line number Diff line number Diff line change
@@ -3,77 +3,77 @@
exports[`Sender Component loading state 1`] = `
<DocumentFragment>
<div
class="ant-sender"
>
<div
class="ant-sender-content"
class="ant-sender"
>
<textarea
class="ant-input ant-input-borderless ant-sender-input"
style="overflow-y: hidden; resize: none;"
/>
<div
class="ant-sender-actions-list"
class="ant-sender-content"
>
<textarea
class="ant-input ant-input-borderless ant-sender-input"
style="overflow-y: hidden; resize: none;"
/>
<div
class="ant-sender-actions-list-presets ant-flex"
class="ant-sender-actions-list"
>
<button
class="ant-btn ant-btn-circle ant-btn-text ant-btn-color-primary ant-btn-variant-text ant-sender-actions-btn ant-sender-actions-btn-loading-button"
type="button"
<div
class="ant-sender-actions-list-presets ant-flex"
>
<svg
class="ant-sender-actions-btn-loading-icon"
color="currentColor"
viewBox="0 0 1000 1000"
xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink"
<button
class="ant-btn ant-btn-circle ant-btn-text ant-btn-color-primary ant-btn-variant-text ant-sender-actions-btn ant-sender-actions-btn-loading-button"
type="button"
>
<title>
Stop Loading
</title>
<rect
fill="currentColor"
height="250"
rx="24"
ry="24"
width="250"
x="375"
y="375"
/>
<circle
cx="500"
cy="500"
fill="none"
opacity="0.45"
r="450"
stroke="currentColor"
stroke-width="100"
/>
<circle
cx="500"
cy="500"
fill="none"
r="450"
stroke="currentColor"
stroke-dasharray="600 9999999"
stroke-width="100"
<svg
class="ant-sender-actions-btn-loading-icon"
color="currentColor"
viewBox="0 0 1000 1000"
xmlns="http://www.w3.org/2000/svg"
xmlns:xlink="http://www.w3.org/1999/xlink"
>
<animatetransform
attributeName="transform"
dur="1s"
from="0 500 500"
repeatCount="indefinite"
to="360 500 500"
type="rotate"
<title>
Stop Loading
</title>
<rect
fill="currentColor"
height="250"
rx="24"
ry="24"
width="250"
x="375"
y="375"
/>
</circle>
</svg>
</button>
<circle
cx="500"
cy="500"
fill="none"
opacity="0.45"
r="450"
stroke="currentColor"
stroke-width="100"
/>
<circle
cx="500"
cy="500"
fill="none"
r="450"
stroke="currentColor"
stroke-dasharray="600 9999999"
stroke-width="100"
>
<animatetransform
attributeName="transform"
dur="1s"
from="0 500 500"
repeatCount="indefinite"
to="360 500 500"
type="rotate"
/>
</circle>
</svg>
</button>
</div>
</div>
</div>
</div>
</div>
</DocumentFragment>
`;

3 changes: 3 additions & 0 deletions components/thought-chain/__tests__/__snapshots__/demo-extend.test.ts.snap
View file
Original file line number Diff line number Diff line change
@@ -1403,6 +1403,7 @@ exports[`renders components/thought-chain/demo/size.tsx extend context correctly
>
<input
class="ant-radio-button-input"
name="test-id"
type="radio"
value="large"
/>
@@ -1423,6 +1424,7 @@ exports[`renders components/thought-chain/demo/size.tsx extend context correctly
<input
checked=""
class="ant-radio-button-input"
name="test-id"
type="radio"
value="middle"
/>
@@ -1442,6 +1444,7 @@ exports[`renders components/thought-chain/demo/size.tsx extend context correctly
>
<input
class="ant-radio-button-input"
name="test-id"
type="radio"
value="small"
/>
3 changes: 3 additions & 0 deletions components/thought-chain/__tests__/__snapshots__/demo.test.ts.snap
View file
Original file line number Diff line number Diff line change
@@ -980,6 +980,7 @@ exports[`renders components/thought-chain/demo/size.tsx correctly 1`] = `
>
<input
class="ant-radio-button-input"
name="test-id"
type="radio"
value="large"
/>
@@ -1000,6 +1001,7 @@ exports[`renders components/thought-chain/demo/size.tsx correctly 1`] = `
<input
checked=""
class="ant-radio-button-input"
name="test-id"
type="radio"
value="middle"
/>
@@ -1019,6 +1021,7 @@ exports[`renders components/thought-chain/demo/size.tsx correctly 1`] = `
>
<input
class="ant-radio-button-input"
name="test-id"
type="radio"
value="small"
/>