Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: peerdep antd version needs to be greater than 5.20.3 because of … #611

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

pokerface9830
Copy link
Contributor

@pokerface9830 pokerface9830 commented Mar 18, 2025

link https://github.com/ant-design/x/issues/596
fix antd version error
peerdep antd version needs to be greater than 5.20.3

Summary by CodeRabbit

  • Chores
    • 调整了依赖项的版本要求,确保在引入非破坏性更新时提供更精准的版本管理,进一步提升系统的稳定性与兼容性。

@pokerface9830 pokerface9830 requested a review from kimteayon March 18, 2025 02:47
Copy link
Contributor

coderabbitai bot commented Mar 18, 2025

📝 Walkthrough

Walkthrough

本次更改修改了 package.json 文件中 peerDependencies 部分,将 antd 包的版本要求从 >=5.0.0 更改为 ^5.20.3。此更新确保将来安装的 antd 版本在不引入破坏性变更的前提下,从 5.20.3 版本开始可自动更新。

Changes

文件 更改说明
package.json 修改了 peerDependenciesantd 的版本,从 >=5.0.0 改为 ^5.20.3

Suggested reviewers

  • li-jia-nan

Poem

我是一只小兔子,跳跃在代码的草原,
依赖更新如春风,把旧版烦恼一扫而空。
antd 新版本,稳健又灵动,
每行代码都闪烁着希望的光芒,
让我们的项目像胡萝卜般甜美生长! 🥕
轻轻一跳,即刻迎接全新风景!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Mar 18, 2025

Preview is ready

Copy link

Walkthrough

This pull request addresses an issue with the antd peer dependency version in the package.json file. The version constraint for antd has been updated from >=5.0.0 to ^5.20.3 to resolve compatibility issues as discussed in issue #596.

Changes

File Summary
package.json Updated antd peer dependency version from >=5.0.0 to ^5.20.3.

@@ -270,7 +270,7 @@
"webpack-bundle-analyzer": "^4.10.2"
},
"peerDependencies": {
"antd": ">=5.0.0",
"antd": "^5.20.3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The peer dependency version for antd has been updated to ^5.20.3. Ensure that this version is compatible with all other dependencies and does not introduce any breaking changes.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (346ba3e) to head (c37462b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files          67       67           
  Lines        1466     1466           
  Branches      372      387   +15     
=======================================
  Hits         1346     1346           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codecov bot commented Mar 18, 2025

Bundle Report

Changes will decrease total bundle size by 3 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
antdx-array-push 134.7kB -3 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: antdx-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
antdx.min.js -3 bytes 134.7kB -0.0%

Copy link

Deploying ant-design-x with  Cloudflare Pages  Cloudflare Pages

Latest commit: c37462b
Status: ✅  Deploy successful!
Preview URL: https://681f3266.ant-design-x.pages.dev
Branch Preview URL: https://fix-antd-version.ant-design-x.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

272-276: 更新 antd 版本要求:此更改将 antdpeerDependencies 中的版本要求从 >=5.0.0 修改为 ^5.20.3。使用 caret (^) 表示只允许大于或等于 5.20.3 且小于 6.0.0 的版本,这样可以保证未来安装的 antd 版本在遵循语义化版本控制下不会引入破坏性变更。请确认项目代码与 antd 的 API 在该版本范围内完全兼容。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 346ba3e and c37462b.

📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: test / react component workflow
  • GitHub Check: build preview
  • GitHub Check: size
  • GitHub Check: Cloudflare Pages

Copy link

size-limit report 📦

Path Size
dist/antdx.min.js 36.63 KB

@afc163 afc163 merged commit fd400e7 into main Mar 18, 2025
16 checks passed
@afc163 afc163 deleted the fix/antd_version branch March 18, 2025 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants