-
-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: peerdep antd version needs to be greater than 5.20.3 because of … #611
Conversation
📝 WalkthroughWalkthrough本次更改修改了 Changes
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses an issue with the Changes
|
@@ -270,7 +270,7 @@ | |||
"webpack-bundle-analyzer": "^4.10.2" | |||
}, | |||
"peerDependencies": { | |||
"antd": ">=5.0.0", | |||
"antd": "^5.20.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The peer dependency version for antd
has been updated to ^5.20.3
. Ensure that this version is compatible with all other dependencies and does not introduce any breaking changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 67 67
Lines 1466 1466
Branches 372 387 +15
=======================================
Hits 1346 1346
Misses 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will decrease total bundle size by 3 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: antdx-array-pushAssets Changed:
|
Deploying ant-design-x with
|
Latest commit: |
c37462b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://681f3266.ant-design-x.pages.dev |
Branch Preview URL: | https://fix-antd-version.ant-design-x.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
272-276
: 更新 antd 版本要求:此更改将antd
在peerDependencies
中的版本要求从>=5.0.0
修改为^5.20.3
。使用 caret (^
) 表示只允许大于或等于 5.20.3 且小于 6.0.0 的版本,这样可以保证未来安装的 antd 版本在遵循语义化版本控制下不会引入破坏性变更。请确认项目代码与 antd 的 API 在该版本范围内完全兼容。
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: test / react component workflow
- GitHub Check: build preview
- GitHub Check: size
- GitHub Check: Cloudflare Pages
size-limit report 📦
|
link https://github.com/ant-design/x/issues/596
fix antd version error
peerdep antd version needs to be greater than 5.20.3
Summary by CodeRabbit