fix rtmp url format #6987
Open
fix rtmp url format #6987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration test codes are added on Enterprise side |
USAMAWIZARD
force-pushed
the
fixRtmpURLFormat
branch
from
199f621 to
0332f5d
Compare
USAMAWIZARD
force-pushed
the
fixRtmpURLFormat
branch
from
0644e3d to
1934a8d
Compare
|
@mekya I have confirmed that the @lastpeony PR works fine with OBS but its not working with ffmpeg , I just did some small changes to make things compatible with ffmpeg , it is not a separate implementation it just handles the case for ffmpeg scenario. I have added the comments to the code explaining the issue and , I have also added integration and unit test codes for this scenario , let me know if you have any concern , Thank you. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6704