Fix leak socket #7565
Fix leak socket #7565
Conversation
…ources even if no header written
|
| if (bsfFilterContextList.isEmpty()) | ||
| { | ||
| writeHeader(); | ||
| if (!exitIfCancelled()) |
There was a problem hiding this comment.
it seems like the cancellation check should not depend on bsfFilterContextList.isEmpty() check.
There was a problem hiding this comment.
@mstyura agreed and updated. Though the check mechanisms there are just extra protective, the real reason behind the socket leak issue is that writeTrailer was not clearing resources when the header is not written yet so the root cause of the issue lies there. I have triggered the integration tests with the new commit and will share a build with you over slack when it passes.
There was a problem hiding this comment.
But why the writeHeader(); is still done in case connection may still be cancelled? Who will close it in such case if code goes to the writeHeader path?
#7543