Skip to content

Add manifests to pom of plugins - #169

Open
golgetahir wants to merge 2 commits into
masterfrom
plugin-install
Open

Add manifests to pom of plugins#169
golgetahir wants to merge 2 commits into
masterfrom
plugin-install

Conversation

@golgetahir

@golgetahir golgetahir commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@sonarqubecloud

sonarqubecloud Bot commented Apr 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'Media Push Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud

sonarqubecloud Bot commented Apr 20, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'Filter Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jantekb
jantekb reviewed Jun 17, 2026
View reviewed changes
Comment thread ClipCreatorPlugin/pom.xml
<archive>
<manifestEntries>
<AMS-Plugin-Name>Clip Creator Plugin</AMS-Plugin-Name>
<AMS-Plugin-Author>Ant Media Inc.</AMS-Plugin-Author>

@jantekb jantekb Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid repeating this over and over for each plugin in this repo, is it possible to move these to the parent pom of plugins? Or find some other place to avoid repeating them

Comment thread ClipCreatorPlugin/pom.xml
<manifestEntries>
<AMS-Plugin-Name>Clip Creator Plugin</AMS-Plugin-Name>
<AMS-Plugin-Author>Ant Media Inc.</AMS-Plugin-Author>
<AMS-Plugin-Version>${project.version}</AMS-Plugin-Version>

@jantekb jantekb Jun 17, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean all plugins version together and get a bump even if just one of them changes?

@sonarqubecloud

sonarqubecloud Bot commented Aug 10, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'Media Push Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud

sonarqubecloud Bot commented Aug 10, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed for 'MoQ Plugin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jantekb jantekb jantekb left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@golgetahir @jantekb