Feature/no red5 parent - #203
Conversation
jantekb
commented
Jun 8, 2026
jantekb
commented
- Detaching from old red5 parent pom
- Upgraded github action versions
- Support branch-specific snapshots
bd7a604 to
e8850c8
Compare
e8850c8 to
a412a42
Compare
a412a42 to
c31eb43
Compare
| <groupId>io.antmedia</groupId> | ||
| <artifactId>parent</artifactId> | ||
| <version>4.0.0-SNAPSHOT</version> | ||
| <version>${revision}</version> |
There was a problem hiding this comment.
This is required for dynamic versioning, as recommended by CI friendly maven versioning https://maven.apache.org/guides/mini/guide-maven-ci-friendly.html
| <configuration> | ||
| <release>${java.version}</release> | ||
| <verbose>false</verbose> | ||
| <fork>false</fork> |
There was a problem hiding this comment.
Was true previously, slowing things down unnecessarily
| <version>${maven-compiler-plugin.version}</version> | ||
| <configuration> | ||
| <release>${java.version}</release> | ||
| <verbose>false</verbose> |
There was a problem hiding this comment.
Was verbose before, flooding CI with low-value log lines. Can be turned on if required anytime, but 99% of the cases it is unnecessary
| </distributionManagement> | ||
| <properties> | ||
| <!-- Override revision with -Drevision=... in CI builds --> | ||
| <revision>4.0.0-SNAPSHOT</revision> |
There was a problem hiding this comment.
This can be easily overridden as needed during CI builds
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up JDK 17 |
There was a problem hiding this comment.
It is faster and easier to start off from a base image that already has Java in it
| cache: 'maven' | ||
| gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }} | ||
| gpg-passphrase: ${{ secrets.GPG_PASSPHRASE }} | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
Keeping action versions up to date
| uses: actions/checkout@v6 | ||
|
|
||
| - run: sudo apt-get update -qq | ||
| - run: sudo apt-get install ffmpeg -qq -y |
There was a problem hiding this comment.
These are unnecessary, unused in this context, so removed it
| key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }} | ||
| restore-keys: ${{ runner.os }}-maven- | ||
|
|
||
| - name: Resolve Maven revision |
There was a problem hiding this comment.
For tag pushes (refs/tags/ams-v*): Extracts the version from the tag name (e.g., ams-v1.2.3 → 1.2.3)
For branch pushes: Appends a branch qualifier to the base version with -SNAPSHOT suffix (e.g., 1.2.3-feature-name-SNAPSHOT)
Strips common prefixes like feature/ or bugfix/
Normalizes the branch name to lowercase and replaces invalid characters with hyphens
Falls back to using the first 8 characters of the commit hash if the branch name is empty
For pull requests: Similar to branches, but uses pr-{PR_NUMBER} as the qualifier (e.g., 1.2.3-pr-42-SNAPSHOT)
The resolved revision is then passed to the Maven deploy command via the -Drevision parameter, allowing different version numbers to be generated automatically based on the build context without modifying the pom.xml file.
6898427 to
cd6200e
Compare
cd6200e to
20eb533
Compare
1 participant
