fix: only call getRecentCommits when needed#105
Open
Zamiell wants to merge 1 commit into
Open
Conversation
Previously, getRecentCommits() was called unconditionally in both versionBump() and versionBumpInfo(). This caused issues in repositories with no git tags because the underlying git describe command would fail with "fatal: No names found, cannot describe anything." This change makes getRecentCommits() only be called when commits are actually needed: - When printCommits is enabled - When release type is 'prompt' (user needs to see version options) - When release type is 'conventional' (need to determine semver change) For explicit release types like 'major', 'minor', 'patch', 'prerelease', etc., commits are not needed and the git describe call is now skipped. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
antfu
reviewed
Jan 19, 2026
Comment on lines
+181
to
+183
| const needsCommits = operation.options.printCommits | ||
| || operation.options.release.type === 'prompt' | ||
| || operation.options.release.type === 'conventional' |
Member
There was a problem hiding this comment.
I am afraid this would be coupled with the implementation located at the other places and might be hard to maintain or cause bugs. How about passing a cache getter so we only get the commits on-demand?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, getRecentCommits() was called unconditionally in both
versionBump() and versionBumpInfo(). This caused issues in repositories
with no git tags because the underlying git describe command would fail
with "fatal: No names found, cannot describe anything."
This change makes getRecentCommits() only be called when commits are
actually needed:
For explicit release types like 'major', 'minor', 'patch', 'prerelease',
etc., commits are not needed and the git describe call is now skipped.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com