Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support vscode with tsx #13

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat: support vscode with tsx #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/detect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,14 @@ async function isRuntimeSupportsTsx() {
) {
return false
}
// Disable in Electron

// not supported in vscode < 1.96: https://github.com/microsoft/vscode/issues/224426
// magic number 10629634 is from
// https://github.com/microsoft/vscode/blob/bee3e32d012157a94cbc431080b743775fe713c5/.npmrc

// eslint-disable-next-line node/prefer-global/process
if (typeof process !== 'undefined' && typeof process.versions.electron === 'string') {
const msBuildVersion = typeof process !== 'undefined' && process.versions['microsoft-build']
if (msBuildVersion && Number(msBuildVersion) < 10629634) {
return false
}
return true
Expand Down
Loading