fix: restore metadata request timeout#274
Open
Perdolique wants to merge 1 commit into
Open
Conversation
Perdolique
force-pushed
the
fix/metadata-request-timeout
branch
from
ecc536b to
34b6d37
Compare
- 🐛 Add a configurable request timeout for package metadata fetches - ⚡ Restore fast timeout handling while still aborting underlying requests - ♻️ Dedupe concurrent package metadata lookups in resolves cache - ✅ Add regression coverage for CLI, timeout, and dedupe flows
Perdolique
force-pushed
the
fix/metadata-request-timeout
branch
from
34b6d37 to
3937271
Compare
Contributor
|
The configurable timeout duration feature is quite important! I've been getting more and more timeouts while using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 Context
Package metadata requests could hang longer than expected in the interactive flow, especially when upstream package metadata APIs were slow or did not settle promptly after abort.
This change restores fast timeout handling, makes the timeout configurable, and avoids duplicate in-flight metadata fetches for the same package.
I'm getting this timeout problem almost every time with packages
drizzle-orm,drizzle-kitanddrizzle-seed. Each of them has almost a hundred dist-tags.📚 Description
This PR adds a new CLI option,
--request-timeout <ms>, and a matching config key,requestTimeout, for controlling how long taze waits for package metadata responses.It also restores fast timeout handling, aborts slow requests, and deduplicates concurrent fetches for the same package so we do not hit the registry multiple times for identical data.