Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define the interface for merging indexes #312

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

define the interface for merging indexes #312

wants to merge 2 commits into from

Conversation

inabao
Copy link
Collaborator

@inabao inabao commented Jan 10, 2025

@inabao inabao self-assigned this Jan 10, 2025
@inabao inabao added the kind/feature New feature or request label Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/engine.cpp 84.37% 5 Missing ⚠️
src/index/hnsw.cpp 93.93% 2 Missing ⚠️
src/index/hnsw_test.cpp 98.07% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #312       +/-   ##
=========================================
+ Coverage      0   88.18%   +88.18%     
=========================================
  Files         0      146      +146     
  Lines         0     9462     +9462     
=========================================
+ Hits          0     8344     +8344     
- Misses        0     1118     +1118     
Flag Coverage Δ
cpp 88.18% <94.59%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/algorithm/hnswlib/hnswalg.cpp 87.34% <100.00%> (ø)
src/algorithm/hnswlib/hnswalg.h 96.87% <ø> (ø)
src/index/hnsw.h 100.00% <ø> (ø)
src/merge_index.cpp 100.00% <100.00%> (ø)
src/index/hnsw_test.cpp 98.54% <98.07%> (ø)
src/index/hnsw.cpp 90.74% <93.93%> (ø)
src/engine.cpp 89.79% <84.37%> (ø)

... and 139 files with indirect coverage changes

Signed-off-by: jinjiabao.jjb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant