Skip to content

Support gno-imi partition strategy #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

dasurax
Copy link
Collaborator

@dasurax dasurax commented Apr 21, 2025

closed: #562

root and others added 2 commits April 22, 2025 15:20
Signed-off-by: suguan.dx <[email protected]>
Signed-off-by: suguan.dx <[email protected]>
@dasurax dasurax force-pushed the support_gno_ini_for_pr branch from b53867b to afd5397 Compare April 22, 2025 07:20
{
"dtype": "float32",
"metric_type": "l2",
"dim": 128,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dim": 960 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not push ?

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 96.75810% with 13 lines in your changes missing coverage. Please review.

❌ Your project check has failed because the head coverage (89.32%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #612      +/-   ##
==========================================
+ Coverage   88.77%   89.32%   +0.55%     
==========================================
  Files         199      202       +3     
  Lines       12735    13102     +367     
==========================================
+ Hits        11305    11703     +398     
+ Misses       1430     1399      -31     
Flag Coverage Δ
cpp 89.32% <96.75%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 92.53% <ø> (ø)
datacell 91.87% <ø> (ø)
index 89.13% <97.06%> (+0.57%) ⬆️
simd 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fba1d...c1f9158. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dasurax dasurax requested a review from LHT129 May 20, 2025 02:26
suguan.dx and others added 3 commits May 20, 2025 13:05
Copy link
Collaborator

@jiaweizone jiaweizone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LHT129 LHT129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wxyucs wxyucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support GNOIMI in ivf index
4 participants