Search to add a separate allocator #716
Conversation
Carrot-77
requested review from
inabao,
wxyucs,
ShawnShawnYou,
LHT129 and
jiaweizone
as code owners
Codecov ReportAttention: Patch coverage is ❌ Your project status has failed because the head coverage (88.73%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #716 +/- ##
==========================================
- Coverage 88.78% 88.73% -0.05%
==========================================
Files 198 199 +1
Lines 12650 12693 +43
==========================================
+ Hits 11231 11263 +32
- Misses 1419 1430 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Carrot-77
force-pushed
the
search_param
branch
2 times, most recently
from
1895dcc to
c76bab7
Compare
wxyucs
added
version/0.15
kind/improvement
wxyucs
added
kind/feature
src/index/hnsw.cpp
Outdated
| @@ -234,6 +235,7 @@ HNSW::knn_search(const DatasetPtr& query, | |||
| ret->Dim(0)->NumElements(1); | |||
| return ret; | |||
| } | |||
| vsag::Allocator* search_alloctor = allocator == nullptr ? allocator_.get() : allocator; | |||
There was a problem hiding this comment.
typo: search_allocator
| @@ -35,7 +35,8 @@ class SparseVectorDataCell : public FlattenInterface { | |||
| Query(float* result_dists, | |||
| const ComputerInterfacePtr& computer, | |||
| const InnerIdType* idx, | |||
| InnerIdType id_count) override { | |||
| InnerIdType id_count, | |||
| Allocator* allocator = nullptr) override { | |||
| auto comp = std::static_pointer_cast<Computer<QuantTmpl>>(computer); | |||
| this->query(result_dists, comp, idx, id_count); | |||
There was a problem hiding this comment.
@wxyucs Here need add param allocator to use custom allocator ?
this->query(result_dists, comp, idx, id_count, allocator);There was a problem hiding this comment.
Search allocator is not used inside query
Signed-off-by: zourunxin.zrx <[email protected]>
No description provided.