-
Notifications
You must be signed in to change notification settings - Fork 42
support index serialization self-description #743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
||
/******************* Load Index from IStream *****************/ | ||
index = nullptr; | ||
if (auto create_index = engine.CreateIndex("hnsw", hnsw_build_paramesters); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: hnsw_build_paramesters -> hnsw_build_parameters
} | ||
|
||
void | ||
HGraph::deserialize_label_info(StreamReader& reader) const { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const
method ?
if (footer != nullptr) { | ||
logger::debug("parse with new version format"); | ||
auto metadata = footer->GetMetadata(); | ||
this->deserialize_basic_info(metadata->Get("basic_info")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check metadata
not null and include basic_info
?
Signed-off-by: Xiangyu Wang <[email protected]>
No description provided.