Skip to content

support index serialization self-description #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

support index serialization self-description #743

wants to merge 15 commits into from

Conversation

wxyucs
Copy link
Collaborator

@wxyucs wxyucs commented May 21, 2025

No description provided.

@wxyucs wxyucs self-assigned this May 21, 2025
@wxyucs wxyucs added the kind/feature New feature or request label May 21, 2025

/******************* Load Index from IStream *****************/
index = nullptr;
if (auto create_index = engine.CreateIndex("hnsw", hnsw_build_paramesters);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: hnsw_build_paramesters -> hnsw_build_parameters

}

void
HGraph::deserialize_label_info(StreamReader& reader) const {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const method ?

if (footer != nullptr) {
logger::debug("parse with new version format");
auto metadata = footer->GetMetadata();
this->deserialize_basic_info(metadata->Get("basic_info"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check metadata not null and include basic_info ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants