Add seccomp argv0 mode for multicall-binary invocation#203
Merged
dylan-conway merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
When the caller has apply-seccomp compiled into its own executable
(busybox-style multicall dispatch), there is no standalone binary on
disk to resolve. seccompConfig.argv0 lets the caller supply the dispatch
name and a verbatim applyPath (e.g. an inherited-fd path like
/proc/self/fd/N); the wrapped invocation becomes
ARGV0=<argv0> <applyPath> <shell> -c <cmd>
and the on-disk getApplySeccompBinaryPath lookup is skipped.
- sandbox-config: optional argv0 string on SeccompConfigSchema (parallel
to ripgrep.argv0)
- linux-sandbox-utils: resolveApplySeccompPrefix helper returns a
shell-ready prefix for both modes; non-argv0 output is byte-identical
to before. Dependency checks short-circuit the disk lookup when argv0
is set. Inline {applyPath?; argv0?} shapes replaced with the
SeccompConfig type.
- sandbox-manager: use SeccompConfig type
- tests: argv0 dependency-check short-circuit, wrapped-command prefix
format, shell-quoting of hostile inputs, argv0-without-applyPath error
ddworken
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the caller has apply-seccomp compiled into its own executable (busybox-style multicall dispatch), there is no standalone binary on disk to resolve.
seccompConfig.argv0lets the caller supply the dispatch name and a verbatimapplyPath(e.g. an inherited-fd path like/proc/self/fd/N); the wrapped invocation becomesand the on-disk
getApplySeccompBinaryPathlookup is skipped.Changes
argv0string onSeccompConfigSchema(parallel toripgrep.argv0)resolveApplySeccompPrefixhelper returns a shell-ready prefix for both modes; non-argv0 output is byte-identical to before. Dependency checks short-circuit the disk lookup whenargv0is set. Inline{applyPath?; argv0?}shapes replaced with theSeccompConfigtype.SeccompConfigtype