fix(streaming): add helpful error message for malformed tool JSON in non-beta path#1268
Open
tao-to-python wants to merge 1 commit intoanthropics:mainfrom
Open
Conversation
…non-beta path The beta streaming path (_beta_messages.py) wraps from_json() with a try-except that provides context about the error. The non-beta path (_messages.py) was missing this, causing raw parser errors like: ValueError: expected ident at line 1 column 11 Add the same try-except wrapper to the non-beta accumulate_event() so users get an actionable message with the malformed JSON included. Fixes anthropics#1265
|
already fix that #1266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes unhelpful raw parser error when model emits malformed JSON during streaming tool use, as reported in #1265.
Problem
The beta path (
_beta_messages.py) already wrapsfrom_json()with a helpful try-except:The non-beta path (
_messages.py) was missing this wrapper, causing raw errors like:No context about what JSON was received or what to do.
Solution
Add the same try-except wrapper to the non-beta
accumulate_event()in_messages.py.Changes
src/anthropic/lib/streaming/_messages.pyfrom_json()with helpful ValueErrorFixes #1265