fix(managed_agents): self-close <img> tags so MDX build does not fail#509
Merged
Conversation
The cookbook-deploy GHA converts notebooks to MDX, and the MDX parser requires self-closing void tags. The two raw HTML <img> tags in data_analyst_agent.ipynb and slack_data_bot.ipynb were missing the trailing /, which broke the production build with: [@mdx-js/rollup] Expected a closing tag for `<img>` (256:1-256:193)
Notebook ChangesThis PR modifies the following notebooks: 📓
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review
Recommendation: APPROVE
Summary
Fixes an MDX build failure by self-closing two <img> tags in Jupyter notebooks. MDX parses markup as JSX, which requires void elements like <img> to use self-closing syntax (<img ... />).
Actionable Feedback (0 items)
No issues found — the fix is correct and complete.
Detailed Review
Code Quality
Both <img> tags are correctly updated from HTML void syntax to JSX/MDX self-closing syntax in data_analyst_agent.ipynb and slack_data_bot.ipynb. The change is surgical and touches only the two affected lines.
Security
No security concerns.
Suggestions
None — this is a minimal, focused fix.
Positive Notes
- Fix correctly targets both affected notebooks
- PR description accurately diagnoses the root cause (MDX void-element requirement), includes the exact error message, and scopes the fix precisely
- No collateral risk: no code cells, logic, imports, or model references changed
martingarramon
added a commit
to martingarramon/claude-cookbooks
that referenced
this pull request
Apr 10, 2026
…env var - Add example_data/sre/logs/checkout-svc.txt — the SRE notebook uploads this file but it was missing, causing FileNotFoundError on run (uses .txt extension because .log is gitignored) - Update sre_incident_responder.ipynb to reference the .txt extension - Add load_dotenv() to CMA_operate_in_production.ipynb so .env users can load GITHUB_TOKEN (4 sibling notebooks already call it) - Use COOKBOOK_MODEL env var in data_analyst_agent.ipynb, matching the pattern used by 7 other managed_agents notebooks Follow-up from PR anthropics#508 bot reviews (code-level items not addressed by anthropics#509, anthropics#511, anthropics#516 which fixed MDX rendering only). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production cookbook deploy
This PR adds the trailing
/on both. Once merged, re-running the cookbook-deploy GHA should publish cleanly.