Repository navigation
Conversation
When one command makes several quiet commits and git show fails or times out on one of them, the commit review goes on with the others and then recorded all of them as reviewed. The next push review skipped the commit nobody had read. Record, and mark as under review, only the commits git could show. The next push or quiet commit reviews the rest. Co-authored-by: mhegazy <mhegazy@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When one Bash call makes several commits whose output is hidden (
git commit -qm a && git commit -qm b), the commit review finds them in the reflog and reads each withgit show. Ifgit showfails or hits its 15 s limit on one of them, the review goes on with the others, and then all of them are recorded as reviewed. The next push review skips the commit nobody read, and a push in the same command does not take it over.Not a regression: 2.0.0 to 2.0.20 do the same.
Fix
Only the commits git could show are recorded as reviewed and marked as under review. The next push review, or the next quiet commit within the reflog window, reviews the rest. A file renamed into code is shown up to the newest commit that was read, so an unread newer one does not hide it.
Effect
Not covered
When two commits of one call change the same file, only the newer commit's diff of that file is sent, as before.
Tests
The model was scripted. On the ARM64 runner reviews are single-shot only, on main too.
Generated by Claude Code