Repository navigation
Conversation
After a finding, the Stop hook stores a new baseline for the next Stop. It took that snapshot when the review had ended, so a change made while the review ran was in the baseline but in no review. The snapshot is now taken before the changes are read, and is stored unless a newer baseline is already there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: after a finding, the Stop hook takes the baseline for the next Stop when the review has ended. A change made while the review runs, by an edit tool or a command, is in that baseline but in no review. It happens when the next turn is at work while the review of the last one is still running.
After: the baseline is taken before the changes are read. A change before it is in this review, a change after it is in the next one.
How
Implications
Not a regression: the released versions tried, from 2.0.0 to 2.0.20, do the same.
Tests
tests/test_baseline_after_review.pyThe sessions use a scripted model. No version bump.
Generated by Claude Code