fix(setup): use Windows venv path on Windows shells#398
Closed
MukundaKatta wants to merge 1 commit intoanthropics:mainfrom
Closed
fix(setup): use Windows venv path on Windows shells#398MukundaKatta wants to merge 1 commit intoanthropics:mainfrom
MukundaKatta wants to merge 1 commit intoanthropics:mainfrom
Conversation
The setup script previously hardcoded .venv/bin/activate which fails on Git Bash / MinGW / Cygwin where the activation script is at .venv/Scripts/activate. Detect via $OSTYPE and pick the right path. Closes anthropics#129
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #129.
On Windows under Git Bash / MinGW / Cygwin, Python's venv puts the activation script at
.venv/Scripts/activate, not.venv/bin/activate. The currentcomputer-use-demo/setup.shhardcodes the Linux/Mac path, so Windows users get aNo such file or directoryerror on line 18.What
Detect Windows shells via
$OSTYPE(msys,win32,cygwin) and source the correct activation path. Linux/macOS behavior is unchanged.Tested
.venv/bin/activate(else branch).ifbranch was not executed on a real Windows host as part of this change; the maintainer may want to confirm on Git Bash / MSYS2 before merging. The condition matches the pattern proposed in the issue and is widely used in cross-platform shell scripts.