ci: replace manual protoc install with arduino/setup-protoc action#52
Merged
iainmcgin merged 1 commit intoanthropics:mainfrom Apr 16, 2026
Conversation
iainmcgin
approved these changes
Apr 12, 2026
Collaborator
iainmcgin
left a comment
iainmcgin
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
- Replace curl+unzip protoc installation with arduino/setup-protoc@v3 across 6 jobs (check, msrv-check, test, clippy, doc, wasm), gaining built-in caching across runs - Remove protoc install from examples job entirely — multiservice uses checked-in generated code and does not need protoc - Update env comment to reflect the new setup Closes anthropics#11 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
auto-merge was automatically disabled
April 16, 2026 12:44
Head branch was pushed to by a user without write access
paikend
force-pushed
the
fix/ci-replace-apt-protoc-with-cached-action
branch
from
b3a8dd1 to
d24022b
Compare
Contributor
Author
|
Rebased onto latest main and re-signed the commit with SSH key to satisfy the branch protection rule (required_signatures). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl + unzipprotoc installation witharduino/setup-protoc@v3across 6 CI jobs (check,msrv-check,test,clippy,doc,wasm), gaining built-in caching across workflow runsexamplesjob entirely —multiservice-exampleuses checked-in generated code and does not invoke protoc at build timePROTOC_VERSIONenv comment to reflect the new setupMotivation
As noted in #11, every CI job was independently downloading protoc on each run.
arduino/setup-protoccaches the binary via@actions/tool-cache, so subsequent runs skip the download entirely.The
examplesjob was installing protoc unnecessarily —multiservice-examplehas nobuild.rsandinclude!s pre-generated code, so protoc is not required. Verified locally withcargo build -p multiservice-examplewithout protoc installed.Changes
curl + unzip + protoc --versionarduino/setup-protoc@v3(2 lines)Net: -38 lines, +21 lines in
ci.yml.Test plan
arduino/setup-protoc@v3supports exact version pinning ("33.5") per READMEcargo build -p multiservice-examplesucceeds without protoc installedCloses #11
🤖 Generated with Claude Code