fix: do not require default features for axum#55
Open
siketyan wants to merge 2 commits intoanthropics:mainfrom
Open
fix: do not require default features for axum#55siketyan wants to merge 2 commits intoanthropics:mainfrom
siketyan wants to merge 2 commits intoanthropics:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the connectrpc crate required default features of the
axumcrate. This created a dependency chain ofaxum/tokio->tokio/net->mio. Sincemiodoes not support WebAssembly (WASM), it was impossible to use this crate in environments like Cloudflare Workers.Because
connectrpcdoes not actually depend on any of the default features, this PR disables them. This change removes the incompatible dependencies and enables the crate to be used in WASM environments.No changes are required to the current crate users.