Fix(skill-creator): specify utf-8 encoding when reading SKILL.md #284
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drfccv
force-pushed
the
fix/creator-validate-encoding
branch
from
501e3ec to
a9848be
Compare
|
i saw some other issues related to encoding on windows, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly specifying utf-8 encoding when reading SKILL.md ensures consistent behavior across different operating systems and environments. It prevents potential UnicodeDecodeError exceptions that may occur if the system default encoding is not utf-8, especially on Windows. This change improves the script's robustness and compatibility when handling non-ASCII characters in SKILL.md files.
