Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was implementing the memory usage function of a redis module data type that used
RM_CreateDict.RM_DictSizejust returns the numele, and I needed the actual bytes for the memory usage. nothing like it exists in the code, so I implemented it. it may be useful to export the function to redis modules so they can report the dictionary memory size if a custom type uses it (my use case exactly).the function is quite simple, combining the
raxTouchfunction, summingraxNodeCurrentLengthon every node. it should be working properly. I thought about doing a redefinition of malloc/realloc which stores the length before the pointer as shown here, but I'm pretty sure the implementation is correct.thanks,
kenny