fix two cases in raxRemove which can be compressed but not#21
Open
zhuer91 wants to merge 1 commit intoantirez:masterfrom
Open
fix two cases in raxRemove which can be compressed but not#21zhuer91 wants to merge 1 commit intoantirez:masterfrom
zhuer91 wants to merge 1 commit intoantirez:masterfrom
Conversation
Owner
|
Thank you, I'll check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two minor problem in raxRemove which omit potential compressible cases:
case 1:
If h->iscompr missed here, the example in annotation will not work.
case 2:
given two nods, say A and B, there are only three cases in which they cannot be merged:
whether A is a key doesn't matter.
As a example, we operates like this:
insert three nil keys "FOOBAR", "FOOTBALL" and "FOO", then remove "FOOTBALL"
In current code, we will get:
"FOO" -> [B]=(nil) -> "AR" -> []=(nil)
which can be merged to:
"FOO" -> "BAR"=(nil) -> []=(nil)
So I changed the judgments:
and here:
and the key data restore code, not list.