Prevent windows platform (GOOS) from attempting to use voidstar_handler#26
Open
herzogp wants to merge 1 commit into
Open
Prevent windows platform (GOOS) from attempting to use voidstar_handler#26herzogp wants to merge 1 commit into
herzogp wants to merge 1 commit into
Conversation
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures
internal/emit.gowhich previously contained implementations for both local_handler and voidstar_handler to separate files, and the voidstar handler is further divided betweenvoidstar_handler.go(for non-windows clients) andvoidstar_stub.go(for windows clients). The windows-based split prevents windows clients to avoid usingdlopen()dlsym()anddlerror()to determine at runtime if the current process as access to/usr/lib/voidstar.soThis has been tested on linux (still works as intended), but never tested on windows.