JavaScript runtime: deprecated usage update, index fixes for deprecated references. #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is enabled for _interp. There is no other way to control this console output right now, seems like missed if check. [in progress]: unintentional exception is fired by Lexer along with passing it through error listener at the same time. This behavior changed. Signed-off-by: Aliaksandr Kukrash <[email protected]>
multiarc
changed the title
ericvergnaud
requested changes
Feb 20, 2024
Signed-off-by: Aliaksandr Kukrash <[email protected]>
multiarc
force-pushed
the
fix/deprecated_usage_and_console_log
branch
from
d10bf6a to
bfb9ab6
Compare
multiarc
changed the title
ericvergnaud
requested changes
Feb 26, 2024
| @@ -8,7 +8,7 @@ import calc from "./generatedCode/calc.js"; | |||
| * @param {string} input | |||
| */ | |||
| function getRewriter(lexerClass, input) { | |||
| const chars = new antlr4.InputStream(input); | |||
| const chars = new antlr4.CharStreams.fromString(input); | |||
There was a problem hiding this comment.
This is a static function, please remove new
There was a problem hiding this comment.
Embarrassing mistake, of course! Fixed.
Signed-off-by: Aliaksandr Kukrash <[email protected]>
ericvergnaud
approved these changes
Feb 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update index files to reference CharStream instead of deprecated InputStream as it's actual type.
Update usage of InputStream to use CharStream instead.