Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript runtime: deprecated usage update, index fixes for deprecated references. #4536

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

multiarc
Copy link
Contributor

@multiarc multiarc commented Feb 19, 2024

Update index files to reference CharStream instead of deprecated InputStream as it's actual type.
Update usage of InputStream to use CharStream instead.

…is enabled for _interp.

There is no other way to control this console output right now, seems like missed if check.
[in progress]: unintentional exception is fired by Lexer along with passing it through error listener at the same time. This behavior changed.

Signed-off-by: Aliaksandr Kukrash <[email protected]>
@multiarc multiarc changed the title Default exception logging (no setting), JavaScript runtime: default exception logging only in debug, deprecated usage update, index fixes for deprecated references. Feb 19, 2024
@multiarc multiarc marked this pull request as draft February 20, 2024 22:41
@multiarc multiarc marked this pull request as ready for review February 25, 2024 20:12
@multiarc multiarc force-pushed the fix/deprecated_usage_and_console_log branch from d10bf6a to bfb9ab6 Compare February 25, 2024 20:14
@multiarc multiarc changed the title JavaScript runtime: default exception logging only in debug, deprecated usage update, index fixes for deprecated references. JavaScript runtime: deprecated usage update, index fixes for deprecated references. Feb 25, 2024
@@ -8,7 +8,7 @@ import calc from "./generatedCode/calc.js";
* @param {string} input
*/
function getRewriter(lexerClass, input) {
const chars = new antlr4.InputStream(input);
const chars = new antlr4.CharStreams.fromString(input);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a static function, please remove new

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embarrassing mistake, of course! Fixed.

Signed-off-by: Aliaksandr Kukrash <[email protected]>
@ericvergnaud ericvergnaud merged commit 1b3150b into antlr:dev Feb 27, 2024
41 of 42 checks passed
@ericvergnaud
Copy link
Contributor

Thanks!

@multiarc multiarc deleted the fix/deprecated_usage_and_console_log branch February 27, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants