fix: Cpp $rule.text fail if $rule is nullptr #4832
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gashmob
force-pushed
the
4777_cpp_rule_text
branch
from
f2e213b to
f0ed454
Compare
|
@Gashmob can you touch this PR in order to re-run the CI ? |
With a grammar like this:
```antlr
rule: (VAL | VAR {
is_constant = false;
}) name=IDENTIFIER (COLON type {
type_name = $type.text; <-- we look this line
})? (EQ value=expression {
value = $value.tree;
})?
```
When generating for Cpp target we get this specific result:
```cpp
type_name = (antlrcpp::downCast<Variable_declarationContext *>(_localctx)->typeContext != nullptr ? _input->getText(antlrcpp::downCast<Variable_declarationContext *>(_localctx)->typeContext->start, antlrcpp::downCast<Variable_declarationContext *>(_localctx)->typeContext->stop) : nullptr);
```
If input doesn't match the `type` branch then we fallback on nullptr. As
of cpp23 standard this line doesn't compile as it waits for
`std::string`.
AS `Token::getText` returns `std::string`, then fallback value should be
empty string
Signed-off-by: Kevin Traini <[email protected]>
Gashmob
force-pushed
the
4777_cpp_rule_text
branch
from
f0ed454 to
4808a13
Compare
|
Up, this issue blocks one of my project, did you know when it is planned for review and merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a grammar like this:
When generating for Cpp target we get this specific result:
If input doesn't match the
typebranch then we fallback on nullptr. As of cpp23 standard this line doesn't compile as it waits forstd::string.AS
Token::getTextreturnsstd::string, then fallback value should be empty string