build: fix location of installed c++ headers#4925
Open
pstieber wants to merge 1 commit into
Open
Conversation
Prior to this fix, include files would be installed in the wrong location. For example, if the install prefix was /usr/local, the headers would be installed in /usr/local/antlr4-runtime instead of /usr/local/include/antlr4-runtime. Signed-off-by: Peter J. Stieber <pstieber@gmail.com>
jmairboeck
reviewed
Mar 25, 2026
| endif() | ||
|
|
||
| set(libantlrcpp_INCLUDE_INSTALL_DIR "${CMAKE_INSTALL_INCLUDEDIR}/antlr4-runtime") | ||
| set(libantlrcpp_INCLUDE_INSTALL_DIR "include/antlr4-runtime") |
Contributor
There was a problem hiding this comment.
This fix is wrong. There are systems which don't use "include" as the include path, e.g. Haiku, which uses "develop/headers". I think the correct fix would be to move the include(GNUInstallDirs) in the parent CMakeLists.txt further up before this subdirectory is added. I missed this apparently in #4109. Sorry for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this fix, include files would be installed in the wrong location. For example, if the install prefix was /usr/local, the headers would be installed in /usr/local/antlr4-runtime instead of /usr/local/include/antlr4-runtime.
This resolves issue #4924