[lua] Fix for #4496 -- add the Antlr4ng port, and fix several broken ports.#4497
Merged
Conversation
Fix broken ports and add Antlr4ng port. The grammar comment is changed to reflect that the header is required not only for Cpp but for Antlr4ng.
Closed
kaby76
changed the title
Member
|
@kaby76 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #4496.
For this PR, I added the Antlr4ng port. A comment in the grammar, which transformGrammar.py modifies to a
@header, was changed to remove the string "C++" because it has to be modified for Antlr4ng as well.In addition, while perusing the code, I noticed that several ports were broken, and the test scripts were also broken. This PR fixes the Cpp, JavaScript, and TypeScript ports for the grammar, but the test scripts are fixed in another PR. #4501