Support scientific notation in sequence_start_clause#4898
Open
Briseglace wants to merge 1 commit into
Open
Conversation
Added `APPROXIMATE_NUM_LIT` to `sequence_start_clause` since it is syntactically valid even if it must be an integer semantically. Fixes antlr#4837
Contributor
Author
|
I noticed that the failing check was also failing in the master branch for my last PR (#4897) even though it passed when the merge commit was created. Please let me know if I you want me to open an issue or if I am wrong an need to change something. |
Contributor
|
"Visual Studio 17 2022 could not find any instance of Visual Studio." Github likely changed the VM image and doesn't install VS2022 as it is old. I'll update this weekend. For now, ignore. |
Contributor
|
Exactly as I thought. They updated the VM images 2 days ago. #4900 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
APPROXIMATE_NUM_LITtosequence_start_clausesince it is syntactically valid even if it must be an integer semantically.Fixes #4837