fix: upgrade effect dependency from pinned 3.3.2 to ^3.20.0 (GHSA-38f7-945m-qr2g)#201
Merged
antoine-coulon merged 5 commits intomainfrom Mar 31, 2026
Merged
Conversation
security vulnerability Agent-Logs-Url: https://github.com/antoine-coulon/skott/sessions/8d5222d5-f224-4bf8-ba37-869ad7359711 Co-authored-by: antoine-coulon <43391199+antoine-coulon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix security issue by updating effect version
fix: upgrade effect dependency from pinned 3.3.2 to ^3.20.0 (GHSA-38f7-945m-qr2g)
Mar 31, 2026
Owner
|
@copilot run "pnpm changeset" to generate a pnpm changeset |
Agent-Logs-Url: https://github.com/antoine-coulon/skott/sessions/5ddfc5f0-b6aa-471b-8814-af36ee56426e Co-authored-by: antoine-coulon <43391199+antoine-coulon@users.noreply.github.com>
Contributor
Author
Done — added a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
effectwas pinned to3.3.2— a 2-year-old version with a high-severity vulnerability (GHSA-38f7-945m-qr2g):AsyncLocalStoragecontext contamination inside Effect fibers under concurrent RPC load. This was surfacing as a transitive security advisory for downstream consumers ofskott.Summary
Upgrades
effectto^3.20.0(resolves to3.21.0), the first patched release.Implementation
packages/skott/package.json:"effect": "3.3.2"→"effect": "^3.20.0"pnpm-lock.yaml: regenerated;effectnow resolves to3.21.0Using a caret range (
^3.20.0) rather than a new pinned version follows the recommendation in the issue and avoids re-pinning to a version that may itself become stale.Testing
All 139 existing unit tests pass without modification — the
effectAPIs used (Effect,Option,Either,Context,Exit,pipe,identity) are stable across this version range.Impacted documentation
No behavioral change; no changeset required.
pnpm changesetat the root of the workspace, affected packages are being bumped (either patch/minor) and a clear description for each of the affected packages was added.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1045629/chrome-linux.zip/home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js(http block)If you need me to access, download, or install something from one of these locations, you can either: