Repository navigation
Update postcss and nanoid to clear two high-severity advisories - #7
Merged
Merged
Conversation
Deploying network-secret with
|
| Latest commit: |
84f421b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5afeb7ee.network-secret.pages.dev |
| Branch Preview URL: | https://fix-npm-audit-advisories.network-secret.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two high-severity advisories
npm auditreports for the website.postcssnanoidExposure
Limited. Both are transitive dependencies of
vite, which is a devDependency:So they only ever ran on the build machine. Neither is bundled into the site, and no visitor of network-secret.pages.dev was exposed to either issue.
Scope of the change
Lockfile only, 7 lines.
web/package.jsonis untouched: no direct dependency was added or removed, and no version range changed. The upgrade is semver-compatible within the existingviterange, so it needednpm audit fixrather thannpm audit fix --force.Verification
npm auditreports 0 vulnerabilities. Web suite 144 tests,npm run checkclean at zero warnings,npm run buildsucceeds, Python suite 140 tests.Note on merge order
This branches from
master, independently of PR #6. Both touchweb/package-lock.json, so whichever merges second will conflict there. Resolving it is a matter of taking the merged lockfile and runningnpm install; there is no semantic overlap, since this PR changes only transitive build-tool versions and #6 addsbcryptjs.